From: "Karicheri, Muralidharan" <m-karicheri2@ti.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"Nori, Sekhar" <nsekhar@ti.com>,
"Hiremath, Vaibhav" <hvaibhav@ti.com>,
"davinci-linux-open-source@linux.davincidsp.com"
<davinci-linux-open-source@linux.davincidsp.com>
Subject: RE: [PATCH - v1 4/6] V4L - vpfe_capture bug fix and enhancements
Date: Wed, 16 Dec 2009 10:45:51 -0600 [thread overview]
Message-ID: <A69FA2915331DC488A831521EAE36FE401625D0DCF@dlee06.ent.ti.com> (raw)
In-Reply-To: <200912160841.57444.hverkuil@xs4all.nl>
hans,
>>
>> Yes, isif_config_bclamp() set values in the register.
>
>Huh? That does not explain why apparently bc->horz.win_h_sz_calc can be
>larger
>than ISIF_HORZ_BC_WIN_H_SIZE_MASK.
because the values come from the user and since we can't use the enum
for the types, I have to make sure the value is within range. Other way
to do is to check the value in the validate() function. I am inclined to
do the validation so that the & statements with masks can be removed while setting it in the register.
>
>Regards,
>
> Hans
>
>>
>> >
>> >It would be interesting to know if people know of good ways of making
>> >awkward
>> >code like this more elegant (or at least less awkward).
>> >
>> >Regards,
>> >
>> > Hans
>> >
>> >--
>> >Hans Verkuil - video4linux developer - sponsored by TANDBERG
>>
>>
>
>--
>Hans Verkuil - video4linux developer - sponsored by TANDBERG
next prev parent reply other threads:[~2009-12-16 16:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-10 17:00 [PATCH - v1 6/6] DaVinci - Adding support for vpfe capture on DM365 m-karicheri2
2009-12-10 17:00 ` [PATCH - v1 2/6] V4L - vpfe capture - Adding DM365 ISIF driver - header files m-karicheri2
2009-12-10 17:00 ` [PATCH - v1 3/6] V4L-vpfe-capture-Adding ISIF driver for DM365 - source m-karicheri2
2009-12-10 17:00 ` [PATCH - v1 1/6] V4L - vpfe-capture : DM365 vpss enhancements m-karicheri2
2009-12-10 17:00 ` [PATCH - v1 5/6] V4L - vpfe capture - build environment for ISIF driver m-karicheri2
2009-12-10 17:00 ` [PATCH - v1 4/6] V4L - vpfe_capture bug fix and enhancements m-karicheri2
2009-12-15 21:05 ` Hans Verkuil
2009-12-15 21:20 ` Hans Verkuil
2009-12-15 23:37 ` Karicheri, Muralidharan
2009-12-16 7:41 ` Hans Verkuil
2009-12-16 16:45 ` Karicheri, Muralidharan [this message]
2009-12-18 5:13 ` Nori, Sekhar
2009-12-10 17:38 ` [PATCH - v1 5/6] V4L - vpfe capture - build environment for ISIF driver Sergei Shtylyov
2009-12-11 20:50 ` Karicheri, Muralidharan
2009-12-15 7:57 ` [PATCH - v1 3/6] V4L-vpfe-capture-Adding ISIF driver for DM365 - source Hans Verkuil
2009-12-15 7:46 ` [PATCH - v1 2/6] V4L - vpfe capture - Adding DM365 ISIF driver - header files Hans Verkuil
2009-12-17 21:34 ` Karicheri, Muralidharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A69FA2915331DC488A831521EAE36FE401625D0DCF@dlee06.ent.ti.com \
--to=m-karicheri2@ti.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=hvaibhav@ti.com \
--cc=hverkuil@xs4all.nl \
--cc=khilman@deeprootsystems.com \
--cc=linux-media@vger.kernel.org \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.