All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yehuda Sadeh Weinraub <yehudasa@gmail.com>
To: Christian Brunner <chb@muc.de>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] rbd: use async write for copy and import
Date: Mon, 2 Aug 2010 13:30:32 -0700	[thread overview]
Message-ID: <AANLkTi=ZyhJy6fd08VRWfrd-XLUkKiyuGvttBEtdhh0X@mail.gmail.com> (raw)
In-Reply-To: <20100802201235.GD4923@chb-desktop>

On Mon, Aug 2, 2010 at 1:12 PM, Christian Brunner <chb@muc.de> wrote:
> Hi Yehuda,
>
> copying images whith "rbd cp" can be quite slow. I did the
> following change to speed up copy and import. Please decide
> if you want to include it.

We'd certainly be happy to be able to speed up those operations. There
are some issues with this implementation, mainly not protecting
aiocnt, and using sleep. Also, it looks like it is unbounded, so with
large images you'd easily run out of memory.
It can be altered to be similar to the patch you supplied for
throttling the qemu-rbd messages, using a conditional variable.

Thanks,
Yehuda

      reply	other threads:[~2010-08-02 20:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-02 20:12 [PATCH] rbd: use async write for copy and import Christian Brunner
2010-08-02 20:30 ` Yehuda Sadeh Weinraub [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=ZyhJy6fd08VRWfrd-XLUkKiyuGvttBEtdhh0X@mail.gmail.com' \
    --to=yehudasa@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=chb@muc.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.