Re: [PATCH] rgw: Lighttpd compatibity.

From: cclien <cclien@gmail.com>
To: Yehuda Sadeh Weinraub <yehudasa@gmail.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH] rgw: Lighttpd compatibity.
Date: Fri, 18 Feb 2011 03:36:15 +0800	[thread overview]
Message-ID: <AANLkTikjD_y+hinSi31LFYQp+AyqtGrcK-7gBPCQy6NK@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=RR4soH3Be1fz+sYC=iTK=CRSG2KvZCaQBUs6c@mail.gmail.com>

Hi Yehuda

Thanks for the advice.

Actually the existing code did the job (filter the query string out).

In rgw_rest.cc:
636   s->path_name_url = FCGX_GetParam("REQUEST_URI", s->fcgx->envp);
637   int pos = s->path_name_url.find('?');
638   if (pos >= 0)
639     s->path_name_url = s->path_name_url.substr(0, pos);

And my workaround uses the filtered REQUEST_URI (s->path_name_url). It
should be much closer to SCRIPT_NAME.

Anyway, I will back to check Lighttpd. :D

Best Regards,
CC

On Fri, Feb 18, 2011 at 3:13 AM, Yehuda Sadeh Weinraub
<yehudasa@gmail.com> wrote:
> On Thu, Feb 17, 2011 at 3:20 AM, cclien <cclien@gmail.com> wrote:
>> Hi all
>>
>> I just tried to deploy a rados gateway with Lighttpd.
>> But it have some trouble parsing object names.
>>
>> Here's what I found in debug log on the non-working copy:
>>    RADOS S3 Gateway: SCRIPT_NAME=/mybucket
>>    RADOS S3 Gateway: REQUEST_URI=/mybucket/ceph.tgz
>
> That doesn't look right. May be some lighttpd configuration tweaking issue?
>
>>
>> I think it will be better to retrive user's request from REQUEST_URI.
>>
>
> The problem with REQUEST_URI is that it'll consist the entire line,
> including any parameters added. So using it requires some extra work
> to check for that (pretty trivial, but you should also take care of
> that).
>
> Thanks,
> Yehuda
>
--
To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html