Re: [PATCH 1/3] Input: hgpk - enable advanced mode through module parameter

From: Daniel Drake <dsd@laptop.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, pgf@laptop.org
Subject: Re: [PATCH 1/3] Input: hgpk - enable advanced mode through module parameter
Date: Tue, 5 Oct 2010 17:59:35 +0100	[thread overview]
Message-ID: <AANLkTinHiCWBb+wZT9niBfGWd3Q-X448CdtMC8yD0NtF@mail.gmail.com> (raw)
In-Reply-To: <20101004174533.GC8321@core.coreip.homeip.net>

On 4 October 2010 18:45, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> Why do you use abs->rel conversion in driver and not rely on the
> standard userspace component handling thouchpads in absolute mode?

Thanks for your feedback.

The justification mainly revolves around a patch that I saved for
later - one that enables pentablet mode for use with a stylus, which
relies on advanced mode. I'll include that patch when I come to
resending them all after this review, so that everything is clear.

But we don't actually want to use it as a tablet, we want to use it as
a mouse pointer (since the touchpad way of using the mouse is not very
reliable) - i.e. we want it to be relative.

I experimented and enabled it in absolute mode, but I couldn't find
any way of making X treat it as relative. It still "behaves absolute"
even with this command:
 xinput set-mode "OLPC HGPK ALPS HGPK" relative

We want it to behave relatively, i.e. if I finish my stylus movement
in one place and continue from another, the mouse cursor should not
jump.

Does this act as justification for doing the relative calculations in
the driver, or is there an option that I'm missing?

Thanks,
Daniel