From: Oleksandr Mazur <oleksandr.mazur@plvision.eu>
To: "jiri@nvidia.com" <jiri@nvidia.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next 00/11] Marvell Prestera driver implementation of devlink functionality.
Date: Thu, 17 Jun 2021 17:30:07 +0000 [thread overview]
Message-ID: <AM0P190MB0738F58BF9FFE2ED8073FA84E40E9@AM0P190MB0738.EURP190.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210609151602.29004-1-oleksandr.mazur@plvision.eu>
> Prestera Switchdev driver implements a set of devlink-based features,
> that include both debug functionality (traps with trap statistics), as well
> as functional rate limiter that is based on the devlink kernel API (interfaces).
> The core prestera-devlink functionality is implemented in the prestera_devlink.c.
> The patch series also extends the existing devlink kernel API with a list of core
> features:
> - devlink: add API for both publish/unpublish port parameters.
> - devlink: add port parameters-specific ops, as current design makes it impossible
> to register one parameter for multiple ports, and effectively distinguish for
> what port parameter_op is called.
As we discussed the storm control (BUM) done via devlink port params topic, and agreed that it shouldn't be done using the devlink API itself, there's an open question i'd like to address: the patch series included, for what i think, list of needed and benefitial changes, and those are the following patches:
> Oleksandr Mazur (2):
...
> net: core: devlink: add port_params_ops for devlink port parameters altering
> drivers: net: netdevsim: add devlink port params usage
> Sudarsana Reddy Kalluru (1):
> net: core: devlink: add apis to publish/unpublish port params
So, should i create a new patch series that would include all of them?
Because in that case the series itself would lack an actual HW usage of it. The only usage would be limited to the netdevsim driver.
next prev parent reply other threads:[~2021-06-17 17:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 15:15 [PATCH net-next 00/11] Marvell Prestera driver implementation of devlink functionality Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 01/11] net: core: devlink: add apis to publish/unpublish port params Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 02/11] net: core: devlink: add dropped stats traps field Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 03/11] net: core: devlink: add port_params_ops for devlink port parameters altering Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 04/11] testing: selftests: net: forwarding: add devlink-required functionality to test (hard) dropped stats field Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 05/11] drivers: net: netdevsim: add devlink trap_drop_counter_get implementation Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 06/11] testing: selftests: drivers: net: netdevsim: devlink: add test case for hard drop statistics Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 07/11] drivers: net: netdevsim: add devlink port params usage Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 08/11] net: marvell: prestera: devlink: add traps/groups implementation Oleksandr Mazur
2021-06-09 15:15 ` [PATCH net-next 09/11] net: marvell: prestera: devlink: add traps with DROP action Oleksandr Mazur
2021-06-09 15:16 ` [PATCH net-next 10/11] net: marvell: prestera: add storm control (rate limiter) implementation Oleksandr Mazur
2021-06-09 17:59 ` Ido Schimmel
2021-06-10 9:31 ` Nikolay Aleksandrov
2021-06-10 12:41 ` Andrew Lunn
2021-06-11 13:19 ` Oleksandr Mazur
2021-06-11 17:08 ` Andrew Lunn
2021-06-13 7:34 ` Ido Schimmel
2021-06-16 7:15 ` kernel test robot
2021-06-16 7:15 ` kernel test robot
2021-06-09 15:16 ` [PATCH net-next 11/11] documentation: networking: devlink: add prestera switched driver Documentation Oleksandr Mazur
2021-06-17 17:30 ` Oleksandr Mazur [this message]
2021-06-17 19:44 ` [PATCH net-next 00/11] Marvell Prestera driver implementation of devlink functionality Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0P190MB0738F58BF9FFE2ED8073FA84E40E9@AM0P190MB0738.EURP190.PROD.OUTLOOK.COM \
--to=oleksandr.mazur@plvision.eu \
--cc=davem@davemloft.net \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.