From: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
"qemu-block@nongnu.org" <qemu-block@nongnu.org>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
Denis Lunev <den@virtuozzo.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"mreitz@redhat.com" <mreitz@redhat.com>
Subject: Re: [PATCH v4 12/12] qcow2_format.py: dump bitmaps header extension
Date: Fri, 5 Jun 2020 16:06:12 +0000 [thread overview]
Message-ID: <AM6PR08MB4070910BF52176ED25D1BC58F4860@AM6PR08MB4070.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <20200604174135.11042-13-vsementsov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
Reviewed-by: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
________________________________
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Sent: Thursday, June 4, 2020 8:41 PM
To: qemu-block@nongnu.org <qemu-block@nongnu.org>
Cc: qemu-devel@nongnu.org <qemu-devel@nongnu.org>; mreitz@redhat.com <mreitz@redhat.com>; kwolf@redhat.com <kwolf@redhat.com>; eblake@redhat.com <eblake@redhat.com>; Denis Lunev <den@virtuozzo.com>; Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>; Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>
Subject: [PATCH v4 12/12] qcow2_format.py: dump bitmaps header extension
Add class for bitmap extension and dump its fields. Further work is to
dump bitmap directory.
Test new functionality inside 291 iotest.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/291 | 4 +++
tests/qemu-iotests/291.out | 33 +++++++++++++++++++++++
tests/qemu-iotests/qcow2_format.py | 42 +++++++++++++++++++++++-------
3 files changed, 70 insertions(+), 9 deletions(-)
[-- Attachment #2: Type: text/html, Size: 2296 bytes --]
next prev parent reply other threads:[~2020-06-05 16:13 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 17:41 [PATCH v4 00/12] iotests: Dump QCOW2 dirty bitmaps metadata Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 01/12] qcow2.py: python style fixes Vladimir Sementsov-Ogievskiy
2020-06-05 10:23 ` Andrey Shinkevich
2020-06-05 19:43 ` Eric Blake
2020-06-06 7:00 ` Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 02/12] qcow2.py: move qcow2 format classes to separate module Vladimir Sementsov-Ogievskiy
2020-06-05 10:51 ` Andrey Shinkevich
2020-06-05 20:14 ` Eric Blake
2020-06-06 7:03 ` Vladimir Sementsov-Ogievskiy
2020-06-08 15:20 ` Eric Blake
2020-06-04 17:41 ` [PATCH v4 03/12] qcow2_format.py: drop new line printing at end of dump() Vladimir Sementsov-Ogievskiy
2020-06-05 10:54 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 04/12] qcow2_format.py: use tuples instead of lists for fields Vladimir Sementsov-Ogievskiy
2020-06-05 11:20 ` Andrey Shinkevich
2020-06-05 20:16 ` Eric Blake
2020-06-06 7:07 ` Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 05/12] qcow2_format.py: use modern string formatting Vladimir Sementsov-Ogievskiy
2020-06-05 11:27 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 06/12] qcow2_format.py: use strings to specify c-type of struct fields Vladimir Sementsov-Ogievskiy
2020-06-05 11:36 ` Andrey Shinkevich
2020-06-05 20:19 ` Eric Blake
2020-06-04 17:41 ` [PATCH v4 07/12] qcow2_format.py: separate generic functionality of structure classes Vladimir Sementsov-Ogievskiy
2020-06-05 12:29 ` Andrey Shinkevich
2020-06-05 12:37 ` Vladimir Sementsov-Ogievskiy
2020-06-04 17:41 ` [PATCH v4 08/12] qcow2_format.py: add field-formatting class Vladimir Sementsov-Ogievskiy
2020-06-05 13:27 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 09/12] qcow2_format.py: QcowHeaderExtension: add dump method Vladimir Sementsov-Ogievskiy
2020-06-05 14:43 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 10/12] qcow2_format: refactor QcowHeaderExtension as a subclass of Qcow2Struct Vladimir Sementsov-Ogievskiy
2020-06-05 15:30 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 11/12] qcow2: QcowHeaderExtension print names for extension magics Vladimir Sementsov-Ogievskiy
2020-06-05 15:42 ` Andrey Shinkevich
2020-06-05 16:26 ` Vladimir Sementsov-Ogievskiy
2020-06-05 16:41 ` Andrey Shinkevich
2020-06-04 17:41 ` [PATCH v4 12/12] qcow2_format.py: dump bitmaps header extension Vladimir Sementsov-Ogievskiy
2020-06-05 16:06 ` Andrey Shinkevich [this message]
2020-06-04 19:14 ` [PATCH v4 00/12] iotests: Dump QCOW2 dirty bitmaps metadata no-reply
2020-06-05 10:02 ` Vladimir Sementsov-Ogievskiy
2020-06-05 20:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR08MB4070910BF52176ED25D1BC58F4860@AM6PR08MB4070.eurprd08.prod.outlook.com \
--to=andrey.shinkevich@virtuozzo.com \
--cc=den@virtuozzo.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.