All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Duan <fugang.duan@nxp.com>
To: Lucas Stach <l.stach@pengutronix.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"patchwork-lst@pengutronix.de" <patchwork-lst@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: RE: [EXT] [PATCH v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled
Date: Fri, 6 Nov 2020 01:28:35 +0000	[thread overview]
Message-ID: <AM8PR04MB7315ADBF697FF08B9BCF202AFFED0@AM8PR04MB7315.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20201105204026.1818219-1-l.stach@pengutronix.de>

From: Lucas Stach <l.stach@pengutronix.de> Sent: Friday, November 6, 2020 4:40 AM
> Since 699cc4dfd140 (tty: serial: imx: add imx earlycon driver), the earlycon part
> of imx serial is a separate driver and isn't necessarily enabled anymore when the
> console is enabled. This causes users to loose the earlycon functionality when
> upgrading their kenrel configuration via oldconfig.
> 
> Enable earlycon by default when IMX_SERIAL_CONSOLE is enabled.
> 
> Fixes: 699cc4dfd140 (tty: serial: imx: add imx earlycon driver)
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> v2: add R-b from Fabio, fix typo in subject
> v3: no changes, adding this note

Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index
> 1044fc387691..28f22e58639c 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -522,6 +522,7 @@ config SERIAL_IMX_EARLYCON
>         depends on OF
>         select SERIAL_EARLYCON
>         select SERIAL_CORE_CONSOLE
> +       default y if SERIAL_IMX_CONSOLE
>         help
>           If you have enabled the earlycon on the Freescale IMX
>           CPU you can make it the earlycon by answering Y to this option.
> --
> 2.20.1


      reply	other threads:[~2020-11-06  1:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05 20:40 [PATCH v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled Lucas Stach
2020-11-06  1:28 ` Andy Duan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM8PR04MB7315ADBF697FF08B9BCF202AFFED0@AM8PR04MB7315.eurprd04.prod.outlook.com \
    --to=fugang.duan@nxp.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=linux-serial@vger.kernel.org \
    --cc=patchwork-lst@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.