RE: [PATCH] iio: st_pressure_spi: Add missing entries SPI to device ID table

From: Denis CIOCCA <denis.ciocca@st.com>
To: Jonathan Cameron <jic23@kernel.org>, Mark Brown <broonie@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: RE: [PATCH] iio: st_pressure_spi: Add missing entries SPI to device ID table
Date: Thu, 30 Sep 2021 18:35:23 +0000	[thread overview]
Message-ID: <AM8PR10MB4801DD2B605277F3D97CAF87EDAA9@AM8PR10MB4801.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20210930173852.208f1815@jic23-huawei>

Hello Jonathan, Mark,

I am not very familiar with how much the kernel would like to keep 'probing id' consistent. I perfectly understand the value of doing this (maintain ID compatibility) but I also see increase confusion in maintaining half in a way and half in another.
I personally think that we should drop the '-press' thing for all the devices since they all are single-chip (meaning that the name used identify univocally that is a pressure sensor).
If you think that compatibility is more important here, I think the patch is fine but this should be done in the i2c part as well so that it's at least congruent withing the driver.

Let me know what you think.

Thanks,
Denis

> -----Original Message-----
> From: Jonathan Cameron <jic23@kernel.org>
> Sent: Thursday, September 30, 2021 9:39 AM
> To: Mark Brown <broonie@kernel.org>
> Cc: Lars-Peter Clausen <lars@metafoo.de>; linux-iio@vger.kernel.org; Denis
> CIOCCA <denis.ciocca@st.com>
> Subject: Re: [PATCH] iio: st_pressure_spi: Add missing entries SPI to device ID
> table
> 
> On Mon, 27 Sep 2021 14:41:53 +0100
> Mark Brown <broonie@kernel.org> wrote:
> 
> > Currently autoloading for SPI devices does not use the DT ID table, it
> > uses SPI modalises. Supporting OF modalises is going to be difficult
> > if not impractical, an attempt was made but has been reverted, so
> > ensure that module autoloading works for this driver by adding SPI IDs
> > for parts that only have a compatible listed.
> >
> > Fixes: 96c8395e2166 ("spi: Revert modalias changes")
> > Signed-off-by: Mark Brown <broonie@kernel.org>
> 
> Whilst these IDs are deprecated, we should at least be consistent that they
> either work or not rather than current situation.
> 
> +CC Denis as driver author.  I'll let it sit on list a little longer so
> +Denis can
> take a look.
> 
> Thanks
> 
> Jonathan
> 
> > ---
> >  drivers/iio/pressure/st_pressure_spi.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/iio/pressure/st_pressure_spi.c
> > b/drivers/iio/pressure/st_pressure_spi.c
> > index 9b2523c5bc94..d6fc954e28f8 100644
> > --- a/drivers/iio/pressure/st_pressure_spi.c
> > +++ b/drivers/iio/pressure/st_pressure_spi.c
> > @@ -97,6 +97,10 @@ static const struct spi_device_id st_press_id_table[]
> = {
> >  	{ LPS33HW_PRESS_DEV_NAME },
> >  	{ LPS35HW_PRESS_DEV_NAME },
> >  	{ LPS22HH_PRESS_DEV_NAME },
> > +	{ "lps001wp-press" },
> > +	{ "lps25h-press", },
> > +	{ "lps331ap-press" },
> > +	{ "lps22hb-press" },
> >  	{},
> >  };
> >  MODULE_DEVICE_TABLE(spi, st_press_id_table);