RE: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size()

From: Henry Wang <Henry.Wang@arm.com>
To: Anthony PERARD <anthony.perard@citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>
Subject: RE: [PATCH 1/2] tools/libxl: Fixes to libxl__domain_set_paging_mempool_size()
Date: Mon, 21 Nov 2022 15:16:36 +0000	[thread overview]
Message-ID: <AS8PR08MB79914380261A37B7EF8F0955920A9@AS8PR08MB7991.eurprd08.prod.outlook.com> (raw)
In-Reply-To: <Y3uPFV6wszfgD4Id@perard.uk.xensource.com>

Hi Andrew,

> -----Original Message-----
> Subject: Re: [PATCH 1/2] tools/libxl: Fixes to
> libxl__domain_set_paging_mempool_size()
> 
> On Mon, Nov 21, 2022 at 02:37:30PM +0000, Andrew Cooper wrote:
> > The error message accidentally printed the bytes value as if it were kB.
> >
> > Furthermore, both b_info.shadow_memkb and shadow_mem are uint64_t,
> meaning
> > there is a risk of overflow if the user specified a stupidly large value in
> > the vm.cfg file.  Check and reject such a condition.
> >
> > Fixes: 7c3bbd940dd8 ("xen/arm, libxl: Revert XEN_DOMCTL_shadow_op;
> use p2m mempool hypercalls")
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > ---
> >
> > v2:
> >  * Retain PRIu64
> >  * Check for overflow
> >
> > For 4.17.  This is a low risk change, removes one overflow case, and makes
> an
> > error message accurate.
> 
> Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>

Release-acked-by: Henry Wang <Henry.Wang@arm.com>

Kind regards,
Henry