From: "Adamson, Andy" <William.Adamson@netapp.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "Adamson, Andy" <William.Adamson@netapp.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] NFSv4.1 Increase NFS4_DEF_SLOT_TABLE_SIZE
Date: Mon, 22 Jul 2013 19:02:03 +0000 [thread overview]
Message-ID: <B0405D50-D8BE-496D-8B72-0E09B13B7D77@netapp.com> (raw)
In-Reply-To: <1374518181.7972.14.camel@leira.trondhjem.org>
On Jul 22, 2013, at 2:36 PM, "Myklebust, Trond" <Trond.Myklebust@netapp.com>
wrote:
> On Fri, 2013-07-19 at 17:09 -0400, andros@netapp.com wrote:
>> From: Andy Adamson <andros@netapp.com>
>>
>> max_session_slots is a ushort. Bump NFS4_DEF_SLOT_TABLE_SIZE to the max ushort
>> value: e.g. ask for 256 slots and let the server negotiate down if needed.
>>
>> Signed-off-by: Andy Adamson <andros@netapp.com>
>> ---
>> fs/nfs/nfs4session.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nfs/nfs4session.h b/fs/nfs/nfs4session.h
>> index 3a153d8..8b7899f 100644
>> --- a/fs/nfs/nfs4session.h
>> +++ b/fs/nfs/nfs4session.h
>> @@ -8,7 +8,7 @@
>> #define __LINUX_FS_NFS_NFS4SESSION_H
>>
>> /* maximum number of slots to use */
>> -#define NFS4_DEF_SLOT_TABLE_SIZE (16U)
>> +#define NFS4_DEF_SLOT_TABLE_SIZE (256U)
>
> Could we please make this smaller? I agree that 16 is too small (as long
> as servers don't do dynamic slot allocation), but 256 is very high for a
> default.
>
> How about 64?
IIIRC the (non-dynamic) session implemenations that I've seen treat the ca_maxrequests coming from the client as the maximum number of session slots that the client can handle - IOW I don't see servers returning a higher ca_maxrequests than was sent by the client. This is why I chose a larger number for the default. It is, after all, a server resource and shouldn't the client grab as many session slots as it can?
-->Andy
>
>> #define NFS4_MAX_SLOT_TABLE (1024U)
>> #define NFS4_NO_SLOT ((u32)-1)
>>
>
> --
> Trond Myklebust
> Linux NFS client maintainer
>
> NetApp
> Trond.Myklebust@netapp.com
> www.netapp.com
next prev parent reply other threads:[~2013-07-22 19:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-19 21:09 [PATCH 1/1] NFSv4.1 Increase NFS4_DEF_SLOT_TABLE_SIZE andros
2013-07-19 23:56 ` Chuck Lever
2013-07-20 13:07 ` Myklebust, Trond
2013-07-22 18:36 ` Myklebust, Trond
2013-07-22 19:02 ` Adamson, Andy [this message]
2013-07-22 19:17 ` Myklebust, Trond
2013-07-22 19:52 ` Adamson, Andy
2013-07-22 20:12 ` Myklebust, Trond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B0405D50-D8BE-496D-8B72-0E09B13B7D77@netapp.com \
--to=william.adamson@netapp.com \
--cc=Trond.Myklebust@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.