From: "Wischer, Timo (ADITG/ESB)" <twischer@de.adit-jv.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: SEGFault when optininal snd_ctl_ext_callback::read_event() not set
Date: Thu, 5 Oct 2017 12:03:14 +0000 [thread overview]
Message-ID: <B0FB33DC1499054591F62C0EF1E013D7684A3E0F@HI2EXCH01.adit-jv.com> (raw)
Hi all,
snd_ctl_ext_callback::read_event() callback is mentioned as optional
(see http://git.alsa-project.org/?p=alsa-lib.git;a=blob;f=include/control_external.h;h=12958e70a5230de9c74029c641a395a2073c8646;hb=refs/heads/master#l239)
but there is no NULL check and the NULL pointer will be called if the read_event function callback pointer is not set.
(see http://git.alsa-project.org/?p=alsa-lib.git;a=blob;f=src/control/control_ext.c;h=56552fa1aa0ef0e6383abf4029b63944a841c2c4;hb=refs/heads/master#l419)
I think a default function has to be provided which will be called when the callback is not set or the read_event() callback should not be marked as optional.
What is your opinion?
Best regards
Timo Wischer
Advanced Driver
Information Technology GmbH
Engineering Software Base (ADITG/ESB)
Robert-Bosch-Str. 200
31139 Hildesheim
Germany
Tel. +49 5121 49 6938
Fax +49 5121 49 6999
twischer@de.adit-jv.com
ADIT is a joint venture company of Robert Bosch GmbH/Robert Bosch Car Multimedia GmbH and DENSO Corporation
Sitz: Hildesheim, Registergericht: Amtsgericht Hildesheim HRB 3438
Geschäftsführung: Wilhelm Grabow, Ken Yaguchi
next reply other threads:[~2017-10-05 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-05 12:03 Wischer, Timo (ADITG/ESB) [this message]
2017-10-05 13:16 ` SEGFault when optininal snd_ctl_ext_callback::read_event() not set Takashi Iwai
2017-10-05 14:28 ` Wischer, Timo (ADITG/ESB)
2017-10-05 14:44 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B0FB33DC1499054591F62C0EF1E013D7684A3E0F@HI2EXCH01.adit-jv.com \
--to=twischer@de.adit-jv.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.