Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.

From: "Javier González" <jg@lightnvm.io>
To: Jens Axboe <axboe@kernel.dk>
Cc: "Johannes Thumshirn" <jthumshirn@suse.de>,
	"Matias Bjørling" <mb@lightnvm.io>,
	linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Matias Bjørling" <matias@cnexlabs.com>
Subject: Re: [PATCH 1/6] lightnvm: pblk: check for failed mempool alloc.
Date: Wed, 6 Sep 2017 17:12:14 +0200	[thread overview]
Message-ID: <B52A428A-99AA-4CE3-8C30-3C2BAA30678D@lightnvm.io> (raw)
In-Reply-To: <d8295f1b-5021-e20b-ffcf-4fbbbe7c70b4@kernel.dk>

[-- Attachment #1: Type: text/plain, Size: 844 bytes --]

> On 6 Sep 2017, at 17.09, Jens Axboe <axboe@kernel.dk> wrote:
> 
> On 09/06/2017 09:08 AM, Johannes Thumshirn wrote:
>> On Wed, Sep 06, 2017 at 05:01:01PM +0200, Javier González wrote:
>>> Check for failed mempool allocations and act accordingly.
>> 
>> Are you sure it is needed? Quoting from mempool_alloc()s Documentation:
>> "[...] Note that due to preallocation, this function *never* fails when called
>> from process contexts. (it might fail if called from an IRQ context.) [...]"
> 
> It's not needed, mempool() will never fail if __GFP_WAIT is set in the
> mask. The use case here is GFP_KERNEL, which does include __GFP_WAIT.

Thanks for the clarification. Do you just drop the patch, or do you want
me to re-send the series?

I see that I do this other places, I'll clean it up for next window.

Thanks,
Javier

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 801 bytes --]