RE: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3

From: "Premi, Sanjeev" <premi@ti.com>
To: Kevin Hilman <khilman@deeprootsystems.com>,
	"Reddy, Teerth" <teerth@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
Date: Tue, 3 Nov 2009 22:02:06 +0530	[thread overview]
Message-ID: <B85A65D85D7EB246BE421B3FB0FBB59301DE27FC52@dbde02.ent.ti.com> (raw)
In-Reply-To: <87zl9lfytn.fsf@deeprootsystems.com>

> -----Original Message-----
> From: linux-omap-owner@vger.kernel.org 
> [mailto:linux-omap-owner@vger.kernel.org] On Behalf Of Kevin Hilman
> Sent: Thursday, August 27, 2009 1:55 PM
> To: Reddy, Teerth
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH]OMAP3:PM :T2 keypad wakeup for OMAP3
> 
> Hi Teerth,
> 
> "Reddy, Teerth" <teerth@ti.com> writes:
> 
> > From : Teerth Reddy <teerth@ti.com>
> >
> > This patch changes for setting the padconf value for sys_nirq line
> > which is connected to T2 INTR1.  This will fix the T2 keypad wakeup
> > issue on OMAP3 SDP.
> >
> > Signed-off-by: Teerth Reddy < teerth@ti.com >
> 
> Patch looks good, thanks.  I'll pull this into PM branch and queue
> in my PM fixes queue for next merge window.
> 
> I did a minor update by adding a comment in the
> enable_board_wakeup_source function stating that this is the
> interrupt pin used for T2.
> 
> Kevin
> 

Teerth, Kevin,

Did you test it with OFF mode enabled?

When I do "echo 1 > /sys/power/enable_off_mode" I don't see resume on the omap3evm.

Schematics for the keypad are/seem to be same for EVM and SDP.

Best regards,
Sanjeev