From: Peter Moon <pomoon@gmail.com>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] cx231xx: Add support for Hauppauge WinTV USB2-FM
Date: Tue, 7 Jun 2011 18:12:55 +0200 [thread overview]
Message-ID: <BANLkTi=B5NmqnFqt5f90VdTEZUCZ_Tvuew@mail.gmail.com> (raw)
In-Reply-To: <BANLkTi=3eyHgiXCsH2uibPsV0L7Eq79fnw@mail.gmail.com>
On Mon, Jun 6, 2011 at 10:00 PM, Devin Heitmueller
<dheitmueller@kernellabs.com> wrote:
> On Mon, Jun 6, 2011 at 3:22 PM, Peter Moon <pomoon@gmail.com> wrote:
>> This patch adds support for the " Hauppauge WinTV USB2-FM" Analog Stick.
>>
>> Signed-off-by: Peter Moon <pomoon@gmail.com>
>
> My only comment is that the func_mode in cx231xx_dif_set_standard()
> should be 0x01, not 0x03. Change that, resubmit the patch after
> testing, and I will put my Reviewed-By on it.
I will make the change you suggest and retest.
> Also, there is actually another USB ID which is the exact same product
> (but targeted at NTSC by default). I'll have to lookup the ID though.
According to the Windows driver inf file that I have, the USB ID of
the NTSC version is 2040:b111.
I can add the USB device definition for the NTSC targeted device as well.
Peter Moon
next prev parent reply other threads:[~2011-06-07 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BANLkTimFT+D3_vZVj5KMiB7jMvq=088Y7A@mail.gmail.com>
2011-06-06 19:22 ` [PATCH] cx231xx: Add support for Hauppauge WinTV USB2-FM Peter Moon
2011-06-06 20:00 ` Devin Heitmueller
2011-06-07 16:12 ` Peter Moon [this message]
2011-06-07 16:17 ` Devin Heitmueller
2011-06-08 18:54 Peter Moon
2011-06-08 18:58 ` Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=B5NmqnFqt5f90VdTEZUCZ_Tvuew@mail.gmail.com' \
--to=pomoon@gmail.com \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.