ping: [PATCH] Set icon for QEMU binary on Mac OS

From: Programmingkid <programmingkidx@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>,
	QEMU devel list <qemu-devel@nongnu.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Subject: ping: [PATCH] Set icon for QEMU binary on Mac OS
Date: Sat, 29 May 2021 10:36:08 -0400	[thread overview]
Message-ID: <BCFCB4F4-5A5A-4CC1-B5D1-4C7D1E396D46@gmail.com> (raw)

Ping, 

please implement this patch. The default icon on Mac OS 11 is not very good looking.


https://lore.kernel.org/qemu-devel/20210202134410.9274-1-programmingkidx@gmail.com/

Before switching the build system over to Meson, an icon was
added to the QEMU binary on Mac OS. This patch adds back that
feature.

Signed-off-by: John Arbuckle <programmingkidx@gmail.com>
---

meson.build
| 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)


diff
--git a/meson.build b/meson.build
index f00b7754fd..7f534f4e75 100644

--- a/meson.build
+++ b/meson.build

@@ -2183,6 +2183,26 @@ foreach target : target_dirs

               link_args: link_args,
               gui_app: exe['gui'])


+# set QEMU's icon on Mac OS
+if targetos == 'darwin'
+    newiconpart1 = custom_target('Icon for ' + exe_name + ' - part 1',
+          depends : emulator,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 1',
+          command : ['Rez', '-append',
+           meson.source_root() + '/pc-bios/qemu.rsrc', '-o',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+
+    custom_target('Icon for ' + exe_name + ' - part 2',
+          depends : newiconpart1,
+          input : emulator,
+          output : 'new icon for ' + exe_name + ' - 2',
+          command : ['SetFile', '-a', 'C',
+           meson.current_build_dir() / exe['name']],
+          build_by_default : true)
+endif
+

    if exe_sign
      emulators += {exe['name'] : custom_target(exe['name'],
                   install: true,
-- 
2.24.3 (Apple Git-128)
