From: Ryan Cai <ycaibb@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <edumazet@google.com>, <davem@davemloft.net>,
<yoshfuji@linux-ipv6.org>, <dsahern@kernel.org>, <ast@kernel.org>,
<daniel@iogearbox.net>, <andrii@kernel.org>, <kafai@fb.com>,
<songliubraving@fb.com>, <yhs@fb.com>, <john.fastabend@gmail.com>,
<kpsingh@kernel.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <bpf@vger.kernel.org>
Subject: Re: [PATCH] ipv4: fix lock leaks
Date: Fri, 21 Jan 2022 12:06:06 +0800 [thread overview]
Message-ID: <BDEF9CF1-016A-48F2-A4F3-8B39CC219B4F@gmail.com> (raw)
In-Reply-To: <20220120194733.6a8b13e6@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Sorry for reporting this false positive. Would be more careful next time. Thank you for your checking.
Best,
Ryan
On 21/1/2022, 11:47 AM, "Jakub Kicinski" <kuba@kernel.org> wrote:
On Fri, 21 Jan 2022 11:11:08 +0800 ycaibb wrote:
> if (seq_sk_match(seq, sk))
> + spin_unlock_bh(lock);
> return sk;
Heh, also you're missing brackets so this is patently buggy.
next prev parent reply other threads:[~2022-01-21 4:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-21 3:11 [PATCH] ipv4: fix lock leaks ycaibb
2022-01-21 3:46 ` Jakub Kicinski
2022-01-21 3:47 ` Jakub Kicinski
2022-01-21 4:06 ` Ryan Cai [this message]
2022-01-21 4:11 ` Alexei Starovoitov
2022-01-21 7:58 ` kernel test robot
2022-01-21 7:58 ` kernel test robot
2022-01-21 9:30 ` kernel test robot
2022-01-21 9:30 ` kernel test robot
2022-01-23 6:17 ` [ipv4] 604258c8f5: BUG:sleeping_function_called_from_invalid_context_at_lib/iov_iter.c kernel test robot
2022-01-23 6:17 ` kernel test robot
2022-01-21 22:57 [PATCH] ipv4: fix lock leaks kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BDEF9CF1-016A-48F2-A4F3-8B39CC219B4F@gmail.com \
--to=ycaibb@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.