From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>,
Damien Le Moal <damien.lemoal@wdc.com>
Subject: Re: [PATCH] blk-zoned: Remove the definition of blk_zone_start()
Date: Tue, 6 Apr 2021 20:21:42 +0000 [thread overview]
Message-ID: <BF78901C-096A-453E-9FC7-ED410FEE17DC@oracle.com> (raw)
In-Reply-To: <20210406200820.15180-1-bvanassche@acm.org>
> On Apr 6, 2021, at 3:08 PM, Bart Van Assche <bvanassche@acm.org> wrote:
>
> Commit e76239a3748c ("block: add a report_zones method") removed the last
> blk_zone_start() call. Hence also remove the definition of this function.
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> block/blk-zoned.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/block/blk-zoned.c b/block/blk-zoned.c
> index c0276b42d9fb..250cb76ee615 100644
> --- a/block/blk-zoned.c
> +++ b/block/blk-zoned.c
> @@ -52,14 +52,6 @@ const char *blk_zone_cond_str(enum blk_zone_cond zone_cond)
> }
> EXPORT_SYMBOL_GPL(blk_zone_cond_str);
>
> -static inline sector_t blk_zone_start(struct request_queue *q,
> - sector_t sector)
> -{
> - sector_t zone_mask = blk_queue_zone_sectors(q) - 1;
> -
> - return sector & ~zone_mask;
> -}
> -
> /*
> * Return true if a request is a write requests that needs zone write locking.
> */
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-04-06 20:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 20:08 [PATCH] blk-zoned: Remove the definition of blk_zone_start() Bart Van Assche
2021-04-06 20:21 ` Himanshu Madhani [this message]
2021-04-06 20:59 ` Chaitanya Kulkarni
2021-04-07 5:17 ` Christoph Hellwig
2021-04-07 20:32 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BF78901C-096A-453E-9FC7-ED410FEE17DC@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.