RE: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support

From: ChunHau Tan <chunhau.tan@starfivetech.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>,
	JeeHeng Sia <jeeheng.sia@starfivetech.com>,
	"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100 support
Date: Wed, 27 Mar 2024 08:24:01 +0000	[thread overview]
Message-ID: <BJSPR01MB0595D132CB5A072A9E61F9C09E34A@BJSPR01MB0595.CHNPR01.prod.partner.outlook.cn> (raw)
In-Reply-To: <6533503e-18e1-4957-96cc-db091e9c46c9@linaro.org>

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, 27 March, 2024 3:50 PM
> To: ChunHau Tan <chunhau.tan@starfivetech.com>; Eugeniy Paltsev
> <Eugeniy.Paltsev@synopsys.com>; Vinod Koul <vkoul@kernel.org>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>;
> Conor Dooley <conor+dt@kernel.org>
> Cc: Leyfoon Tan <leyfoon.tan@starfivetech.com>; JeeHeng Sia
> <jeeheng.sia@starfivetech.com>; dmaengine@vger.kernel.org;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 1/2] dt-bindings: dma: snps,dw-axi-dmac: Add JH8100
> support
> 
> On 27/03/2024 03:51, Tan Chun Hau wrote:
> > Add support for StarFive JH8100 SoC in Sysnopsys Designware AXI DMA
> > controller.
> >
> > Both JH8100 and JH7110 require reset operation in device probe.
> > However, JH8100 doesn't need to apply different configuration on
> > CH_CFG registers.
> 
> This is a friendly reminder during the review process.
> 
> It looks like you received a tag and forgot to add it.
> 
> If you do not know the process, here is a short explanation:
> Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions,
> under or above your Signed-off-by tag. Tag is "received", when provided in a
> message replied to you on the mailing list. Tools like b4 can help here. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for tags received on the version they apply.
> 
> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitt
> ing-patches.rst#L577
> 
> If a tag was not added on purpose, please state why and what changed.

Hi Krzysztof, thank you very much for the feedback,
Sorry I overlooked it.
Do you prefer I resend V2 patch or send a V3 patch to include the Acked-by ?
Thank you.

> 
> Best regards,
> Krzysztof