Re: [PATCH] zonefs: Fix file size of zones in full condition

From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: Shinichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Subject: Re: [PATCH] zonefs: Fix file size of zones in full condition
Date: Wed, 17 Feb 2021 23:41:52 +0000	[thread overview]
Message-ID: <BL0PR04MB651446594B654329EE392477E7869@BL0PR04MB6514.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210217095811.2517221-1-shinichiro.kawasaki@wdc.com

On 2021/02/17 18:58, Shin'ichiro Kawasaki wrote:
> Per ZBC/ZAC/ZNS specifications, write pointers may not have valid values
> when zones are in full condition. However, when zonefs mounts a zoned
> block device, zonefs refers write pointers to set file size even when
> the zones are in full condition. This results in wrong file size. To fix
> this, refer maximum file size in place of write pointers for zones in
> full condition.
> 
> Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> Fixes: 8dcc1a9d90c1 ("fs: New zonefs file system")
> Cc: <stable@vger.kernel.org> # 5.6+
> ---
>  fs/zonefs/super.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/fs/zonefs/super.c b/fs/zonefs/super.c
> index bec47f2d074b..3fe933b1010c 100644
> --- a/fs/zonefs/super.c
> +++ b/fs/zonefs/super.c
> @@ -250,6 +250,9 @@ static loff_t zonefs_check_zone_condition(struct inode *inode,
>  		}
>  		inode->i_mode &= ~0222;
>  		return i_size_read(inode);
> +	case BLK_ZONE_COND_FULL:
> +		/* The write pointer of full zones is invalid. */
> +		return zi->i_max_size;
>  	default:
>  		if (zi->i_ztype == ZONEFS_ZTYPE_CNV)
>  			return zi->i_max_size;
> 

Applied to for-5.12. Thanks !


-- 
Damien Le Moal
Western Digital Research