RE: [patch V2 13/33] x86/apic/vector: Provide MSI parent domain

From: "Tian, Kevin" <kevin.tian@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	LKML <linux-kernel@vger.kernel.org>
Cc: "x86@kernel.org" <x86@kernel.org>, Joerg Roedel <joro@8bytes.org>,
	"Will Deacon" <will@kernel.org>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
	Marc Zyngier <maz@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	Jason Gunthorpe <jgg@mellanox.com>,
	"Jiang, Dave" <dave.jiang@intel.com>,
	Alex Williamson <alex.williamson@redhat.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	Logan Gunthorpe <logang@deltatee.com>,
	"Raj, Ashok" <ashok.raj@intel.com>, Jon Mason <jdmason@kudzu.us>,
	Allen Hubbe <allenbh@gmail.com>
Subject: RE: [patch V2 13/33] x86/apic/vector: Provide MSI parent domain
Date: Wed, 23 Nov 2022 08:16:24 +0000	[thread overview]
Message-ID: <BN9PR11MB5276223A2114DD96420C7B1D8C0C9@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221121091327.217466288@linutronix.de>

> From: Thomas Gleixner <tglx@linutronix.de>
> Sent: Monday, November 21, 2022 10:38 PM
> 
> +bool pci_dev_has_default_msi_parent_domain(struct pci_dev *dev)
> +{
> +	struct irq_domain *domain = dev_get_msi_domain(&dev->dev);
> 
> -int pci_msi_prepare(struct irq_domain *domain, struct device *dev, int nvec,
> -		    msi_alloc_info_t *arg)
> +	if (!domain)
> +		domain = dev_get_msi_domain(&dev->bus->dev);
> +	if (!domain)
> +		return false;
> +
> +	return domain == x86_vector_domain;

the function name is about parent domain but there is no check on
the parent flag. Probably just remove 'parent'?

> +/**
> + * x86_init_dev_msi_info - Domain info setup for MSI domains
> + * @dev:		The device for which the domain should be created
> + * @domain:		The (root) domain providing this callback

what is the purpose of '(root)'? it's also used by intermediate domain i.e. IR.

> +
> +	/*
> +	 * Mask out the domain specific MSI feature flags which are not
> +	 * supported by the real parent.
> +	 */
> +	info->flags			&= pops->supported_flags;
> +	/* Enforce the required flags */
> +	info->flags			|=
> X86_VECTOR_MSI_FLAGS_REQUIRED;
> +
> +	/* This is always invoked from the top level MSI domain! */
> +	info->ops->msi_prepare		= x86_msi_prepare;
> +
> +	info->chip->irq_ack		= irq_chip_ack_parent;
> +	info->chip->irq_retrigger	= irq_chip_retrigger_hierarchy;
> +	info->chip->flags		|= IRQCHIP_SKIP_SET_WAKE |
> +					   IRQCHIP_AFFINITY_PRE_STARTUP;

Above are executed twice for both IR and vector after next patch comes.
Could skip it for IR.