From: "Tian, Kevin" <kevin.tian@intel.com>
To: Ethan Zhao <haifeng.zhao@linux.intel.com>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>,
"dwmw2@infradead.org" <dwmw2@infradead.org>,
"will@kernel.org" <will@kernel.org>,
"robin.murphy@arm.com" <robin.murphy@arm.com>,
"lukas@wunner.de" <lukas@wunner.de>
Cc: "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v9 5/5] iommu/vt-d: don't loop for timeout ATS Invalidation request forever
Date: Fri, 29 Dec 2023 08:17:06 +0000 [thread overview]
Message-ID: <BN9PR11MB5276E70591021395F1ED90D28C9DA@BN9PR11MB5276.namprd11.prod.outlook.com> (raw)
In-Reply-To: <bb3a8a4c-6dad-4347-9076-0f28d1e23de3@linux.intel.com>
> From: Ethan Zhao <haifeng.zhao@linux.intel.com>
> Sent: Thursday, December 28, 2023 9:10 PM
>
> On 12/28/2023 4:38 PM, Tian, Kevin wrote:
> >> From: Ethan Zhao <haifeng.zhao@linux.intel.com>
> >> Sent: Thursday, December 28, 2023 8:17 AM
> >>
> >>
> >> - if (rc == -EAGAIN)
> >> + if (rc == -EAGAIN && type !=QI_DIOTLB_TYPE && type !=
> >> QI_DEIOTLB_TYPE)
> >> goto restart;
> >>
> > this change is moot.
> >
> > -EAGAIN is set only when hardware detects a ATS invalidation completion
> > timeout in qi_check_fault(). so above just essentially kills the restart logic.
>
> This change is intended to break the restar login when device-TLB
>
> invalidation timeout happens, we don't know how long the ITE took
>
> if the device is just no reponse.
if in the end the agreement is to remove the restart logic, then do it.
it's not good to introduce a change which essentially kills the restart
logic but still keeps the related code.
next prev parent reply other threads:[~2023-12-29 8:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 0:16 [RFC PATCH v8 0/5] fix vt-d hard lockup when hotplug ATS capable device Ethan Zhao
2023-12-28 0:16 ` [RFC PATCH v9 1/5] iommu/vt-d: add flush_target_dev member to struct intel_iommu and pass device info to all ATS Invalidation functions Ethan Zhao
2023-12-28 8:10 ` Tian, Kevin
2023-12-28 13:20 ` Ethan Zhao
2023-12-28 0:16 ` [RFC PATCH v9 2/5] iommu/vt-d: break out ATS Invalidation if target device is gone Ethan Zhao
2023-12-28 8:30 ` Tian, Kevin
2023-12-28 13:03 ` Ethan Zhao
2023-12-29 8:06 ` Tian, Kevin
2023-12-29 9:07 ` Ethan Zhao
2023-12-29 9:19 ` Ethan Zhao
2023-12-28 13:35 ` Ethan Zhao
2023-12-28 0:16 ` [RFC PATCH v9 3/5] PCI: make pci_dev_is_disconnected() helper public for other drivers Ethan Zhao
2023-12-28 0:16 ` [RFC PATCH v9 4/5] iommu/vt-d: don't issue ATS Invalidation request when device is disconnected Ethan Zhao
2023-12-28 0:16 ` [RFC PATCH v9 5/5] iommu/vt-d: don't loop for timeout ATS Invalidation request forever Ethan Zhao
2023-12-28 8:38 ` Tian, Kevin
2023-12-28 13:10 ` Ethan Zhao
2023-12-29 8:17 ` Tian, Kevin [this message]
2023-12-29 9:24 ` Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR11MB5276E70591021395F1ED90D28C9DA@BN9PR11MB5276.namprd11.prod.outlook.com \
--to=kevin.tian@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=haifeng.zhao@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.