From: Vadim Pasternak <vadimp@nvidia.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
Michael Shych <michaelsh@nvidia.com>
Subject: RE: [PATCH platform-next 09/10] Documentation/ABI: Add new line card attributes for mlxreg-io sysfs interfaces
Date: Tue, 19 Oct 2021 09:04:03 +0000 [thread overview]
Message-ID: <BN9PR12MB53813DC207D19E3398DB3083AFBD9@BN9PR12MB5381.namprd12.prod.outlook.com> (raw)
In-Reply-To: <bb2330cf-07db-e9df-67bd-de8e62650a0e@redhat.com>
> -----Original Message-----
> From: Hans de Goede <hdegoede@redhat.com>
> Sent: Tuesday, October 19, 2021 11:57 AM
> To: Vadim Pasternak <vadimp@nvidia.com>
> Cc: platform-driver-x86@vger.kernel.org; Michael Shych
> <michaelsh@nvidia.com>
> Subject: Re: [PATCH platform-next 09/10] Documentation/ABI: Add new line
> card attributes for mlxreg-io sysfs interfaces
>
> Hi,
>
> On 10/2/21 11:32, Vadim Pasternak wrote:
> > Add documentation for the new attributes for line cards:
> > - CPLDs versioning.
> > - Write protection control for 'nvram' devices.
> > - Line card reset reasons.
> > - Enabling burning of FPGA and CPLDs.
> > - Enabling burning of FPGA and gearbox SPI flashes,
> > - Enabling power of whole line card.
> > - Enabling power of QSFP ports equipped on line card.
> > - The maximum powered required for line card feeding.
> > - Line card configuration Id.
> >
> > Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
> > Reviewed-by: Michael Shych <michaelsh@nvidia.com>
>
> Applying this gave the following warnings:
>
> Applying: Documentation/ABI: Add new line card attributes for mlxreg-io
> sysfs interfaces
> /home/hans/projects/linux/.git/worktrees/platform-drivers-x86/rebase-
> apply/patch:44: space before tab in indent.
> If the system is in locked-down mode writing this file will not
> /home/hans/projects/linux/.git/worktrees/platform-drivers-x86/rebase-
> apply/patch:76: space before tab in indent.
> If the system is in locked-down mode writing these files will
> /home/hans/projects/linux/.git/worktrees/platform-drivers-x86/rebase-
> apply/patch:100: space before tab in indent.
> If the system is in locked-down mode writing these files will
> warning: 3 lines add whitespace errors.
>
> I've fixed this up locally.
Thank you very much for fixing it.
>
> FYI the 3 "If the system is in locked-down mode writing this file will not"
> lines started with <tab><space><tab> which I've replaced with <tab><tab>.
>
> Regards,
>
> Hans
>
>
> > ---
> > .../ABI/stable/sysfs-driver-mlxreg-io | 103 ++++++++++++++++++
> > 1 file changed, 103 insertions(+)
> >
> > diff --git a/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> > index 6ef6979c9448..b25e963ec0fa 100644
> > --- a/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> > +++ b/Documentation/ABI/stable/sysfs-driver-mlxreg-io
> > @@ -361,3 +361,106 @@ Description: This file allows to unlock ASIC
> after thermal shutdown event.
> > Default is 1.
> >
> > The file is read/write.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/cpld1_pn
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/cpld1_version
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/cpld1_version_min
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: These files show with which CPLD major and minor versions
> > + and part number has been burned CPLD device on line card.
> > +
> > + The files are read only.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/fpga1_pn
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/fpga1_version
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/fpga1_version_min
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: These files show with which FPGA major and minor versions
> > + and part number has been burned FPGA device on line card.
> > +
> > + The files are read only.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/vpd_wp
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: This file allow to overwrite line card VPD hardware write
> > + protection mode. When attribute is set 1 - write protection is
> > + disabled, when 0 - enabled.
> > + Default is 0.
> > + If the system is in locked-down mode writing this file will not
> > + be allowed.
> > + The purpose if this file is to allow line card VPD burning
> > + during production flow.
> > +
> > + The file is read/write.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/reset_aux_pwr_or_ref
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/reset_dc_dc_pwr_fail
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/reset_fpga_not_done
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/reset_from_chassis
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/reset_line_card
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-
> io.*/hwmon/hwmon*/reset_pwr_off_from_chassis
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: These files show the line reset cause, as following: power
> > + auxiliary outage or power refresh, DC-to-DC power failure,
> FPGA reset
> > + failed, line card reset failed, power off from chassis.
> > + Value 1 in file means this is reset cause, 0 - otherwise. Only
> one of
> > + the above causes could be 1 at the same time, representing
> only last
> > + reset cause.
> > +
> > + The files are read only.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/cpld_upgrade_en
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/fpga_upgrade_en
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: These files allow CPLD and FPGA burning. Value 1 in file
> means burning
> > + is enabled, 0 - otherwise.
> > + If the system is in locked-down mode writing these files will
> > + not be allowed.
> > + The purpose of these files to allow line card CPLD and FPGA
> > + upgrade through the JTAG daisy-chain.
> > +
> > + The files are read/write.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/qsfp_pwr_en
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/pwr_en
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: These files allow to power on/off all QSFP ports and whole
> line card.
> > + The attributes are set 1 for power on, 0 - for power off.
> > +
> > + The files are read/write.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/agb_spi_burn_en
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/fpga_spi_burn_en
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: These files allow gearboxes and FPGA SPI flash burning.
> > + The attributes are set 1 to enable burning, 0 - to disable.
> > + If the system is in locked-down mode writing these files will
> > + not be allowed.
> > + The purpose of these files to allow line card Gearboxes and
> FPGA
> > + burning during production flow.
> > +
> > + The file is read/write.
> > +
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/max_power
> > +What: /sys/devices/platform/mlxplat/i2c_mlxcpld.*/i2c-
> */i2c-*/i2c-*/*-0032/mlxreg-io.*/hwmon/hwmon*/config
> > +Date: October 2021
> > +KernelVersion: 5.16
> > +Contact: Vadim Pasternak <vadimp@nvidia.com>
> > +Description: These files provide the maximum powered required for line
> card
> > + feeding and line card configuration Id.
> > +
> > + The files are read only.
> >
prev parent reply other threads:[~2021-10-19 9:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-02 9:32 [PATCH platform-next 00/10] platform: mellanox: Introduce initial chassis management support for modular Ethernet system Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 01/10] platform_data/mlxreg: Add new type to support modular systems Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 02/10] platform/x86: mlx-platform: Add initial support for new modular system Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 03/10] platform/mellanox: mlxreg-hotplug: Extend logic for hotplug devices operations Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 04/10] platform/x86: mlx-platform: Configure notifier callbacks for modular system Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 05/10] platform/mellanox: mlxreg-io: Extend number of hwmon attributes Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 06/10] platform_data/mlxreg: Add new field for secured access Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 07/10] platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices Vadim Pasternak
[not found] ` <76a93a22-a3ff-e65f-1334-defb886724dc@redhat.com>
[not found] ` <6d9e4402-a8c2-d043-4129-4da6b250ea53@redhat.com>
2021-10-19 8:57 ` Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 08/10] Documentation/ABI: Add new attributes for mlxreg-io sysfs interfaces Vadim Pasternak
2021-10-02 9:32 ` [PATCH platform-next 09/10] Documentation/ABI: Add new line card " Vadim Pasternak
2021-10-19 8:57 ` Hans de Goede
2021-10-19 9:04 ` Vadim Pasternak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN9PR12MB53813DC207D19E3398DB3083AFBD9@BN9PR12MB5381.namprd12.prod.outlook.com \
--to=vadimp@nvidia.com \
--cc=hdegoede@redhat.com \
--cc=michaelsh@nvidia.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.