From: Sonal Santan <sonals@xilinx.com>
To: Tom Rix <trix@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-fpga@vger.kernel.org" <linux-fpga@vger.kernel.org>,
Max Zhen <maxz@xilinx.com>, Lizhi Hou <lizhih@xilinx.com>,
Michal Simek <michals@xilinx.com>,
Stefano Stabellini <stefanos@xilinx.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview
Date: Tue, 8 Dec 2020 21:40:44 +0000 [thread overview]
Message-ID: <BY5PR02MB6260399E717A00FFEE32F290BBCD0@BY5PR02MB6260.namprd02.prod.outlook.com> (raw)
In-Reply-To: <457f9fad-f108-26de-3cdb-b367a4782ef2@redhat.com>
Hello Tom,
> -----Original Message-----
> From: Tom Rix <trix@redhat.com>
> Sent: Sunday, December 6, 2020 8:31 AM
> To: Sonal Santan <sonals@xilinx.com>; linux-kernel@vger.kernel.org
> Cc: Sonal Santan <sonals@xilinx.com>; linux-fpga@vger.kernel.org; Max Zhen
> <maxz@xilinx.com>; Lizhi Hou <lizhih@xilinx.com>; Michal Simek
> <michals@xilinx.com>; Stefano Stabellini <stefanos@xilinx.com>;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview
>
> On 11/28/20 4:00 PM, Sonal Santan wrote:
> > Hello,
> >
> > This patch series adds management physical function driver for Xilinx
> > Alveo PCIe accelerator cards,
> > https://www.xilinx.com/products/boards-and-kits/alveo.html
> > This driver is part of Xilinx Runtime (XRT) open source stack.
>
> A few general things.
>
> Use scripts/get_maintainer.pl to find who a patch should go to, i should have
> been on the cc line.
>
Will do.
> Each patch should at a minimum pass scripts/checkpatch.pl, none do.
>
Looks like a few files missed our checkpatch process. Will address in the
upcoming patch series.
> Looking broadly at the files, there are competing names xrt or alveo.
>
> It seems like xrt is the dfl equivalent, so maybe
>
> drivers/fpga/alveo should be drivers/fpga/xrt
>
Agreed. Will address in the next patch series.
> There are a lot of files with unnecessary prefixes
>
> ex/
>
> fpga/alveo/include/xrt-ucs.h could just be fpga/alveo/include/ucs.h
>
Would work on separating xrt infrastructure and subdevs header files
into separate directories and drop the xrt prefix.
> individual subdev's may not belong in the fpga subsystem.
>
> I think it would be better to submit these one at a time as is done for dfl.
>
In the upcoming patch revision, will drop the subdevs except bare minimum
necessary to perform bitstream download.
> So this will not block getting the basics done, in the next revision, can you leave
> the subdev's out ?
>
>
Thanks for the feedback.
-Sonal
>
> Because of the checkpatch.pl failures, I will wait for the next revision.
>
> Tom
>
prev parent reply other threads:[~2020-12-08 21:41 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-29 0:00 [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview Sonal Santan
2020-11-29 0:00 ` [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers Sonal Santan
2020-12-01 4:54 ` Moritz Fischer
2020-12-02 21:24 ` Max Zhen
2020-12-02 23:10 ` Moritz Fischer
2020-12-03 3:38 ` Max Zhen
2020-12-03 4:36 ` Moritz Fischer
2020-12-04 1:17 ` Max Zhen
2020-12-04 4:18 ` Moritz Fischer
2020-11-29 0:00 ` [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files Sonal Santan
2020-12-01 4:27 ` Moritz Fischer
2020-12-02 18:57 ` Sonal Santan
2020-12-02 23:47 ` Moritz Fischer
2020-11-29 0:00 ` [PATCH Xilinx Alveo 3/8] fpga: xrt: infrastructure support for xmgmt driver Sonal Santan
2020-11-29 0:00 ` [PATCH Xilinx Alveo 4/8] fpga: xrt: core infrastructure for xrt-lib module Sonal Santan
2020-11-29 0:00 ` [PATCH Xilinx Alveo 5/8] fpga: xrt: platform drivers for subsystems in shell partition Sonal Santan
2020-11-29 0:00 ` [PATCH Xilinx Alveo 6/8] fpga: xrt: header file for platform and parent drivers Sonal Santan
2020-11-29 0:00 ` [PATCH Xilinx Alveo 7/8] fpga: xrt: Alveo management physical function driver Sonal Santan
2020-12-01 20:51 ` Moritz Fischer
[not found] ` <BY5PR02MB60683E3470179E6AD10FEE26B9F20@BY5PR02MB6068.namprd02.prod.outlook.com>
2020-12-04 6:22 ` Sonal Santan
2020-12-02 3:00 ` Xu Yilun
2020-12-04 4:40 ` Max Zhen
2020-11-29 0:00 ` [PATCH Xilinx Alveo 8/8] fpga: xrt: Kconfig and Makefile updates for XRT drivers Sonal Santan
2020-11-30 18:08 ` [PATCH Xilinx Alveo 0/8] Xilinx Alveo/XRT patch overview Rob Herring
2020-12-01 19:39 ` Sonal Santan
2020-12-02 2:14 ` Xu Yilun
2020-12-02 5:33 ` Sonal Santan
2020-12-06 16:31 ` Tom Rix
2020-12-08 21:40 ` Sonal Santan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR02MB6260399E717A00FFEE32F290BBCD0@BY5PR02MB6260.namprd02.prod.outlook.com \
--to=sonals@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhih@xilinx.com \
--cc=maxz@xilinx.com \
--cc=michals@xilinx.com \
--cc=stefanos@xilinx.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.