From: "Tan, Ley Foon" <ley.foon.tan@intel.com>
To: Randy Dunlap <rdunlap@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Mark Salter <msalter@redhat.com>,
Aurelien Jacquiot <jacquiot.aurelien@gmail.com>,
"linux-c6x-dev@linux-c6x.org" <linux-c6x-dev@linux-c6x.org>
Subject: RE: [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h files
Date: Thu, 10 Dec 2020 01:55:21 +0000 [thread overview]
Message-ID: <BY5PR11MB3893310F750FB2F0AE587AC7CCCB0@BY5PR11MB3893.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20201209204657.6676-1-rdunlap@infradead.org>
> -----Original Message-----
> From: Randy Dunlap <rdunlap@infradead.org>
> Sent: Thursday, December 10, 2020 4:47 AM
> To: linux-kernel@vger.kernel.org
> Cc: Randy Dunlap <rdunlap@infradead.org>; Tejun Heo <tj@kernel.org>;
> Jens Axboe <axboe@kernel.dk>; linux-block@vger.kernel.org; Tan, Ley Foon
> <ley.foon.tan@intel.com>; Mark Salter <msalter@redhat.com>; Aurelien
> Jacquiot <jacquiot.aurelien@gmail.com>; linux-c6x-dev@linux-c6x.org
> Subject: [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h
> files
>
> When building block/blk-iocost.c on arch/x6x/ or arch/nios2/, the build fails
> due to missing the <asm/local64.h> file.
>
> Fix this by adding local64.h as a "generic-y" file in their respective Kbuild files,
> so that they will use a copy of <asm-generic/local64.h> instead (copied to
> arch/*/include/generated/local64.h by the build system).
>
> c6x or nios2 build error:
> ../block/blk-iocost.c:183:10: fatal error: asm/local64.h: No such file or
> directory
> 183 | #include <asm/local64.h>
>
> Fixes: 5e124f74325d ("blk-iocost: use local[64]_t for percpu stat")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Jens Axboe <axboe@kernel.dk>
> Cc: linux-block@vger.kernel.org
> Cc: Ley Foon Tan <ley.foon.tan@intel.com>
> Cc: Mark Salter <msalter@redhat.com>
> Cc: Aurelien Jacquiot <jacquiot.aurelien@gmail.com>
> Cc: linux-c6x-dev@linux-c6x.org
> ---
> arch/c6x/include/asm/Kbuild | 1 +
> arch/nios2/include/asm/Kbuild | 1 +
> 2 files changed, 2 insertions(+)
>
> --- linux-next-20201208.orig/arch/c6x/include/asm/Kbuild
> +++ linux-next-20201208/arch/c6x/include/asm/Kbuild
> @@ -1,5 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0
> generic-y += extable.h
> generic-y += kvm_para.h
> +generic-y += local64.h
> generic-y += mcs_spinlock.h
> generic-y += user.h
> --- linux-next-20201208.orig/arch/nios2/include/asm/Kbuild
> +++ linux-next-20201208/arch/nios2/include/asm/Kbuild
> @@ -2,6 +2,7 @@
> generic-y += cmpxchg.h
> generic-y += extable.h
> generic-y += kvm_para.h
> +generic-y += local64.h
> generic-y += mcs_spinlock.h
> generic-y += spinlock.h
> generic-y += user.h
For nios2:
Acked-by: Ley Foon Tan <ley.foon.tan@intel.com>
Regards
Ley Foon
next prev parent reply other threads:[~2020-12-10 1:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 20:46 [PATCH] block: blk-iocost: fix build for ARCH with missing local64.h files Randy Dunlap
2020-12-10 1:55 ` Tan, Ley Foon [this message]
2020-12-10 6:07 ` Christoph Hellwig
2020-12-10 6:16 ` Randy Dunlap
2020-12-10 6:18 ` Christoph Hellwig
2020-12-10 8:18 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR11MB3893310F750FB2F0AE587AC7CCCB0@BY5PR11MB3893.namprd11.prod.outlook.com \
--to=ley.foon.tan@intel.com \
--cc=axboe@kernel.dk \
--cc=jacquiot.aurelien@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-c6x-dev@linux-c6x.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msalter@redhat.com \
--cc=rdunlap@infradead.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.