From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Satya Tangirala <satyat@google.com>,
John Stultz <john.stultz@linaro.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 4/4] block: memory allocations in bounce_clone_bio must not fail
Date: Wed, 24 Feb 2021 20:32:59 +0000 [thread overview]
Message-ID: <BYAPR04MB4965717FB9F5EE97FF20A475869F9@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20210224072407.46363-5-hch@lst.de
On 2/23/21 23:29, Christoph Hellwig wrote:
> The caller can't cope with a failure from bounce_clone_bio, so
> use __GFP_NOFAIL for the passthrough case. bio_alloc_bioset already
> won't fail due to the use of mempools.
>
> And yes, we need to get rid of this bock layer bouncing code entirely
> sooner or later..
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
next prev parent reply other threads:[~2021-02-24 20:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 7:24 bio_kmalloc related fixes for 5.12 Christoph Hellwig
2021-02-24 7:24 ` [PATCH 1/4] block-crypto-fallback: use a bio_set for splitting bios Christoph Hellwig
2021-02-24 16:17 ` Satya Tangirala
2021-02-24 23:23 ` Eric Biggers
2021-02-24 7:24 ` [PATCH 2/4] block: fix bounce_clone_bio for passthrough bios Christoph Hellwig
2021-02-24 20:30 ` Chaitanya Kulkarni
2021-02-24 7:24 ` [PATCH 3/4] block: remove the gfp_mask argument to bounce_clone_bio Christoph Hellwig
2021-02-24 20:30 ` Chaitanya Kulkarni
2021-02-24 7:24 ` [PATCH 4/4] block: memory allocations in bounce_clone_bio must not fail Christoph Hellwig
2021-02-24 11:19 ` Ming Lei
2021-02-24 16:12 ` Christoph Hellwig
2021-02-25 2:21 ` Ming Lei
2021-02-24 20:32 ` Chaitanya Kulkarni [this message]
2021-02-24 15:55 ` bio_kmalloc related fixes for 5.12 Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB4965717FB9F5EE97FF20A475869F9@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=john.stultz@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=satyat@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.