From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: "André Almeida" <andrealmeid@collabora.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "corbet@lwn.net" <corbet@lwn.net>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"kernel@collabora.com" <kernel@collabora.com>,
"krisman@collabora.com" <krisman@collabora.com>
Subject: Re: [PATCH v2 4/4] coding-style: add explanation about pr_fmt macro
Date: Fri, 13 Sep 2019 22:18:04 +0000 [thread overview]
Message-ID: <BYAPR04MB57491969A325583BDDBC7DA486B30@BYAPR04MB5749.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190913220300.422869-5-andrealmeid@collabora.com
I'm not super familier with the format, will let someone do the
final review.
In general looks good.
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 09/13/2019 03:04 PM, André Almeida wrote:
> The pr_fmt macro is useful to format log messages printed by pr_XXXX()
> functions. Add text to explain the purpose of it, how to use and an
> example.
>
> Signed-off-by: André Almeida<andrealmeid@collabora.com>
> Cc: Jonathan Corbet<corbet@lwn.net>
> ---
> Changes from v1:
> - Add Jonathan as explict Cc
> - Replace "include/printk.h" by "#include <linux/kernel.h>
> - Add note about #undef
> - Replace hardcore string by KBUILD_MODNAME at the example
> ---
next prev parent reply other threads:[~2019-09-13 22:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-13 22:02 [PATCH v2 0/4] null_blk: fixes around nr_devices and log improvements André Almeida
2019-09-13 22:02 ` [PATCH v2 1/4] null_blk: do not fail the module load with zero devices André Almeida
2019-09-13 22:15 ` Chaitanya Kulkarni
2019-09-13 22:17 ` Bart Van Assche
2019-09-13 22:37 ` Chaitanya Kulkarni
2019-09-13 22:02 ` [PATCH v2 2/4] null_blk: match the type of parameter nr_devices André Almeida
2019-09-13 22:15 ` Chaitanya Kulkarni
2019-09-13 22:02 ` [PATCH v2 3/4] null_blk: format pr_* logs with pr_fmt André Almeida
2019-09-13 22:16 ` Chaitanya Kulkarni
2019-09-13 22:03 ` [PATCH v2 4/4] coding-style: add explanation about pr_fmt macro André Almeida
2019-09-13 22:18 ` Chaitanya Kulkarni [this message]
2019-09-14 7:50 ` Jonathan Corbet
2019-09-16 13:38 ` André Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB57491969A325583BDDBC7DA486B30@BYAPR04MB5749.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=andrealmeid@collabora.com \
--cc=axboe@kernel.dk \
--cc=corbet@lwn.net \
--cc=kernel@collabora.com \
--cc=krisman@collabora.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.