From: Pawel Laszczak <pawell@cadence.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"Daisy.Barrera@siriusxm.com" <Daisy.Barrera@siriusxm.com>,
"Cliff.Holden@siriusxm.com" <Cliff.Holden@siriusxm.com>,
"arnd@arndb.de" <arnd@arndb.de>,
"tony@atomide.com" <tony@atomide.com>,
"jdelvare@suse.de" <jdelvare@suse.de>,
"neal_liu@aspeedtech.com" <neal_liu@aspeedtech.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"egtvedt@samfundet.no" <egtvedt@samfundet.no>,
"biju.das.jz@bp.renesas.com" <biju.das.jz@bp.renesas.com>,
"herve.codina@bootlin.com" <herve.codina@bootlin.com>
Subject: RE: [PATCH 3/4] usb: cdns2: Add tracepoints for CDNS2 driver
Date: Thu, 16 Feb 2023 11:36:14 +0000 [thread overview]
Message-ID: <BYAPR07MB53814D13CAF0AC674AD00317DDA09@BYAPR07MB5381.namprd07.prod.outlook.com> (raw)
In-Reply-To: <Y+4SCXeMUgQhpADE@kroah.com>
>
>On Thu, Feb 16, 2023 at 05:54:10AM -0500, Pawel Laszczak wrote:
>> Patch adds the series of tracepoints that can be used for debugging
>> issues detected in driver.
>>
>> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>> ---
>> drivers/usb/gadget/udc/cdns2/Makefile | 2 +
>> drivers/usb/gadget/udc/cdns2/cdns2-debug.h | 200 +++++++
>> drivers/usb/gadget/udc/cdns2/cdns2-ep0.c | 26 +-
>> drivers/usb/gadget/udc/cdns2/cdns2-gadget.c | 52 +-
>> drivers/usb/gadget/udc/cdns2/cdns2-trace.c | 11 +
>> drivers/usb/gadget/udc/cdns2/cdns2-trace.h | 609 ++++++++++++++++++++
>> 6 files changed, 897 insertions(+), 3 deletions(-) create mode
>> 100644 drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>> create mode 100644 drivers/usb/gadget/udc/cdns2/cdns2-trace.c
>> create mode 100644 drivers/usb/gadget/udc/cdns2/cdns2-trace.h
>>
>> diff --git a/drivers/usb/gadget/udc/cdns2/Makefile
>> b/drivers/usb/gadget/udc/cdns2/Makefile
>> index 7c746e6d53c2..a1ffbbe2e768 100644
>> --- a/drivers/usb/gadget/udc/cdns2/Makefile
>> +++ b/drivers/usb/gadget/udc/cdns2/Makefile
>> @@ -1,5 +1,7 @@
>> # SPDX-License-Identifier: GPL-2.0
>> # define_trace.h needs to know how to find our header
>> +CFLAGS_cdns2-trace.o := -I$(src)
>>
>> obj-$(CONFIG_USB_CDNS2_UDC) += cdns2-udc-pci.o
>> cdns2-udc-pci-$(CONFIG_USB_CDNS2_UDC) += cdns2-pci.o cdns2-gadget.o
>cdns2-ep0.o
>> +cdns2-udc-pci-$(CONFIG_TRACING) += cdns2-trace.o
>> diff --git a/drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>> b/drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>> new file mode 100644
>> index 000000000000..3a80f3fbdcd3
>> --- /dev/null
>> +++ b/drivers/usb/gadget/udc/cdns2/cdns2-debug.h
>> @@ -0,0 +1,200 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * Cadence USBHS-DEV Driver.
>> + * Debug header file.
>> + *
>> + * Copyright (C) 2023 Cadence.
>> + *
>> + * Author: Pawel Laszczak <pawell@cadence.com> */
>> +
>> +#ifndef __LINUX_CDNS2_DEBUG
>> +#define __LINUX_CDNS2_DEBUG
>> +
>> +static inline const char *cdns2_decode_usb_irq(char *str, size_t size,
>> + u8 usb_irq, u8 ext_irq)
>
><snip>
>
>Why are all of these big functions declared as inline? Do they really work as
>inline functions if you only reference them in a trace callback?
>
Yes, driver reference them only in trace callback.
The big function are used only once in code, so it seems reasonable to use them as inline.
I don't know how they will be used by compiler.
Thanks,
Pawel Laszczak
next prev parent reply other threads:[~2023-02-16 11:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 10:54 [PATCH 0/4] Introduced new Cadence USBHS Driver Pawel Laszczak
2023-02-16 10:54 ` [PATCH 1/4] usb: cdns2: Device side header file for CDNS2 driver Pawel Laszczak
2023-02-16 11:24 ` Greg KH
2023-02-16 11:53 ` Pawel Laszczak
2023-02-16 10:54 ` [PATCH 2/4] usb: cdns2: Add main part of Cadence USBHS driver Pawel Laszczak
2023-02-16 11:26 ` Greg KH
2023-02-17 7:12 ` kernel test robot
2023-02-16 10:54 ` [PATCH 3/4] usb: cdns2: Add tracepoints for CDNS2 driver Pawel Laszczak
2023-02-16 11:22 ` Greg KH
2023-02-16 11:36 ` Pawel Laszczak [this message]
2023-02-18 20:19 ` kernel test robot
2023-02-16 10:54 ` [PATCH 4/4] MAINTAINERS: add Cadence USBHS driver entry Pawel Laszczak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB53814D13CAF0AC674AD00317DDA09@BYAPR07MB5381.namprd07.prod.outlook.com \
--to=pawell@cadence.com \
--cc=Cliff.Holden@siriusxm.com \
--cc=Daisy.Barrera@siriusxm.com \
--cc=arnd@arndb.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=egtvedt@samfundet.no \
--cc=gregkh@linuxfoundation.org \
--cc=herve.codina@bootlin.com \
--cc=jdelvare@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=neal_liu@aspeedtech.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.