From: "\"Kai Mäkisara (Kolumbus)\"" <kai.makisara@kolumbus.fi>
To: "Seymour, Shane M" <shane.seymour@hpe.com>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"James Bottomley (JBottomley@Odin.com)" <JBottomley@Odin.com>
Subject: Re: [PATCH] st: allow debug output to be enabled or disabled via sysfs
Date: Tue, 13 Oct 2015 23:12:52 +0300 [thread overview]
Message-ID: <C6AFF410-BC3F-4AD0-93AA-F30DFBAA91ED@kolumbus.fi> (raw)
In-Reply-To: <DDB9C85B850785449757F9914A034FCB444ABDC8@G4W3219.americas.hpqcorp.net>
> On 12.10.2015, at 7.31, Seymour, Shane M <shane.seymour@hpe.com> wrote:
>
>
> Change st driver to allow enabling or disabling debug output
> via sysfs file /sys/bus/scsi/drivers/st/debug_flag.
>
> Previously the only way to enable debug output was:
>
> 1. loading the driver with the module parameter debug_flag=1
> 2. an ioctl call (this method was also the only way to dynamically
> disable debug output).
>
> To use the ioctl you need a second tape drive (if you are
> actively testing the first tape drive) since a second process
> cannot open the first tape drive if it is in use.
>
Good justification for the feature.
Acked-by: Kai Mäkisara <kai.makisara@kolumbus.fi>
Thanks,
Kai
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-10-13 20:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 4:31 [PATCH] st: allow debug output to be enabled or disabled via sysfs Seymour, Shane M
2015-10-12 15:01 ` Laurence Oberman
2015-10-13 20:12 ` "Kai Mäkisara (Kolumbus)" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C6AFF410-BC3F-4AD0-93AA-F30DFBAA91ED@kolumbus.fi \
--to=kai.makisara@kolumbus.fi \
--cc=JBottomley@Odin.com \
--cc=linux-scsi@vger.kernel.org \
--cc=shane.seymour@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.