From: Amitoj Kaur Chawla <amitoj1606@gmail.com>
To: Bernd Petrovitsch <bernd@petrovitsch.priv.at>
Cc: mchehab@kernel.org, Greg KH <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree()
Date: Sat, 8 Jul 2017 18:55:48 -0400 [thread overview]
Message-ID: <CA+5yK5FA3hLctjv-ysEspMveg+_M+JqvsM+UuEj88NTwX=4Sjg@mail.gmail.com> (raw)
In-Reply-To: <1499504311.3472.13.camel@petrovitsch.priv.at>
On Sat, Jul 8, 2017 at 4:58 AM, Bernd Petrovitsch
<bernd@petrovitsch.priv.at> wrote:
> On Fri, 2017-07-07 at 20:41 -0400, Amitoj Kaur Chawla wrote:
> [...]
>> --- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
>> +++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_cmd.c
>> @@ -117,11 +117,7 @@ void *atomisp_kernel_zalloc(size_t bytes, bool
>> zero_mem)
>> */
>> void atomisp_kernel_free(void *ptr)
>> {
>> - /* Verify if buffer was allocated by vmalloc() or kmalloc()
>> */
>> - if (is_vmalloc_addr(ptr))
>> - vfree(ptr);
>> - else
>> - kfree(ptr);
>> + kvfree(ptr);
>> }
>>
>> /*
>
> Why not get rid of the trivial wrapper function completely?
>
Oh yes, i'll send a v2.
Amitoj
prev parent reply other threads:[~2017-07-08 22:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 0:41 [PATCH 2/2] staging: media: atomisp2: Replace kfree()/vfree() with kvfree() Amitoj Kaur Chawla
2017-07-08 8:58 ` Bernd Petrovitsch
2017-07-08 22:55 ` Amitoj Kaur Chawla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+5yK5FA3hLctjv-ysEspMveg+_M+JqvsM+UuEj88NTwX=4Sjg@mail.gmail.com' \
--to=amitoj1606@gmail.com \
--cc=bernd@petrovitsch.priv.at \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.