All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Coco Li <lixiaoyan@google.com>,
	netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net 1/2] udp: using datalen to cap ipv6 udp max gso segments
Date: Thu, 23 Dec 2021 22:48:50 -0500	[thread overview]
Message-ID: <CA+FuTSc3-bsLjz+qXKYZ_G-7yUTQnGguzE8mLVFDyXdwvaGFWA@mail.gmail.com> (raw)
In-Reply-To: <20211223192256.1c91fe7a@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>

On Thu, Dec 23, 2021 at 10:23 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Thu, 23 Dec 2021 19:19:22 -0800 Jakub Kicinski wrote:
> > On Thu, 23 Dec 2021 22:24:40 +0000 Coco Li wrote:
> > > The max number of UDP gso segments is intended to cap to
> > > UDP_MAX_SEGMENTS, this is checked in udp_send_skb().
> > >
> > > skb->len contains network and transport header len here, we should use
> > > only data len instead.
> > >
> > > This is the ipv6 counterpart to the below referenced commit,
> > > which missed the ipv6 change
> > >
> > > Fixes: 158390e45612 ("udp: using datalen to cap max gso segments")
> >
> > I'm gonna replace the Fixes tag with:
> >
> > Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> >
> > hope that's okay.
>
> Or I'll fumble the git command and accidentally push as is... Whatever.

Thanks. I was in two minds which commit to use. From a backport to
stable point of view, it should not matter in practice.

  reply	other threads:[~2021-12-24  3:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-23 22:24 [PATCH net 1/2] udp: using datalen to cap ipv6 udp max gso segments Coco Li
2021-12-23 22:24 ` [PATCH net 2/2] selftests: Calculate udpgso segment count without header adjustment Coco Li
2021-12-24  3:19 ` [PATCH net 1/2] udp: using datalen to cap ipv6 udp max gso segments Jakub Kicinski
2021-12-24  3:22   ` Jakub Kicinski
2021-12-24  3:48     ` Willem de Bruijn [this message]
2021-12-24  3:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+FuTSc3-bsLjz+qXKYZ_G-7yUTQnGguzE8mLVFDyXdwvaGFWA@mail.gmail.com \
    --to=willemdebruijn.kernel@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=lixiaoyan@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.