From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Xie He <xie.he.0141@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Network Development <netdev@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
Krzysztof Halasa <khc@pm.waw.pl>
Subject: Re: [PATCH net-next v6 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb
Date: Sat, 31 Oct 2020 10:25:49 -0400 [thread overview]
Message-ID: <CA+FuTScDa4NEo0xh1Uu+cB8QZ5mbVs6QvP0=xkritTzS9U7TYw@mail.gmail.com> (raw)
In-Reply-To: <20201031004918.463475-5-xie.he.0141@gmail.com>
On Fri, Oct 30, 2020 at 8:49 PM Xie He <xie.he.0141@gmail.com> wrote:
>
> 1.
> Change the skb->len check from "<= 4" to "< 4".
> At first we only need to ensure a 4-byte header is present. We indeed
> normally need the 5th byte, too, but it'd be more logical and cleaner
> to check its existence when we actually need it.
>
> 2.
> Add an fh->ea2 check to the initial checks in fr_rx. fh->ea2 == 1 means
> the second address byte is the final address byte. We only support the
> case where the address length is 2 bytes. If the address length is not
> 2 bytes, the control field and the protocol field would not be the 3rd
> and 4th byte as we assume. (Say it is 3 bytes, then the control field
> and the protocol field would be the 4th and 5th byte instead.)
>
> Cc: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Cc: Krzysztof Halasa <khc@pm.waw.pl>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
next prev parent reply other threads:[~2020-10-31 14:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 0:49 [PATCH net-next v6 0/5] net: hdlc_fr: Improve fr_rx and add support for any Ethertype Xie He
2020-10-31 0:49 ` [PATCH net-next v6 1/5] net: hdlc_fr: Simpify fr_rx by using "goto rx_drop" to drop frames Xie He
2020-10-31 14:32 ` Willem de Bruijn
2020-10-31 15:18 ` Xie He
2020-10-31 16:01 ` Xie He
2020-10-31 19:47 ` Willem de Bruijn
2020-10-31 20:39 ` Jakub Kicinski
2020-10-31 22:27 ` Xie He
2020-10-31 0:49 ` [PATCH net-next v6 2/5] net: hdlc_fr: Change the use of "dev" in fr_rx to make the code cleaner Xie He
2020-10-31 0:49 ` [PATCH net-next v6 3/5] net: hdlc_fr: Do skb_reset_mac_header for skbs received on normal PVC devices Xie He
2020-10-31 0:49 ` [PATCH net-next v6 4/5] net: hdlc_fr: Improve the initial checks when we receive an skb Xie He
2020-10-31 14:25 ` Willem de Bruijn [this message]
2020-10-31 17:05 ` Xie He
2020-10-31 0:49 ` [PATCH net-next v6 5/5] net: hdlc_fr: Add support for any Ethertype Xie He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+FuTScDa4NEo0xh1Uu+cB8QZ5mbVs6QvP0=xkritTzS9U7TYw@mail.gmail.com' \
--to=willemdebruijn.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.