From: Rae Moar <rmoar@google.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: David Gow <davidgow@google.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Brendan Higgins <brendan.higgins@linux.dev>,
Maxime Ripard <mripard@kernel.org>,
linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org,
Chaitanya Kumar <chaitanya.kumar.borah@intel.com>,
Jani <jani.saarinen@intel.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] kunit: device: Unregister the kunit_bus on shutdown
Date: Wed, 7 Feb 2024 16:11:38 -0500 [thread overview]
Message-ID: <CA+GJov4zrcbiANMgJ5uSQs6Siv0+NAB5big0bec-WWgkhfFJ+Q@mail.gmail.com> (raw)
In-Reply-To: <878r3wcs7e.fsf@intel.com>
On Wed, Feb 7, 2024 at 8:36 AM Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Fri, 02 Feb 2024, Rae Moar <rmoar@google.com> wrote:
> > On Thu, Feb 1, 2024 at 1:06 AM David Gow <davidgow@google.com> wrote:
> >>
> >> If KUnit is built as a module, and it's unloaded, the kunit_bus is not
> >> unregistered. This causes an error if it's then re-loaded later, as we
> >> try to re-register the bus.
> >>
> >> Unregister the bus and root_device on shutdown, if it looks valid.
> >>
> >> In addition, be more specific about the value of kunit_bus_device. It
> >> is:
> >> - a valid struct device* if the kunit_bus initialised correctly.
> >> - an ERR_PTR if it failed to initialise.
> >> - NULL before initialisation and after shutdown.
> >>
> >> Fixes: d03c720e03bd ("kunit: Add APIs for managing devices")
> >> Signed-off-by: David Gow <davidgow@google.com>
> >
> > Hello,
> >
> > I have tested this with modules and it looks good to me!
> >
> > Thanks!
> > -Rae
> >
> > Reviewed-by: Rae Moar <rmoar@google.com>
>
> Thanks for the patch and review!
>
> Is this on its way to some v6.8-rc's? The regression in -rc1 is hurting
> our CI.
Hello!
This patch has been accepted on the kselftest/kunit-fixes branch
(https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit-fixes&id=829388b725f8d266ccec32a2f446717d8693eaba)
and is heading towards a future v6.8-rc.
Thanks!
-Rae
>
>
> Thanks,
> Jani.
>
>
> --
> Jani Nikula, Intel
prev parent reply other threads:[~2024-02-07 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 6:04 [PATCH] kunit: device: Unregister the kunit_bus on shutdown David Gow
2024-02-01 6:04 ` David Gow
2024-02-01 15:47 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-02-01 17:28 ` ✓ Fi.CI.IGT: " Patchwork
2024-02-02 20:16 ` [PATCH] " Rae Moar
2024-02-07 13:35 ` Jani Nikula
2024-02-07 21:11 ` Rae Moar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+GJov4zrcbiANMgJ5uSQs6Siv0+NAB5big0bec-WWgkhfFJ+Q@mail.gmail.com \
--to=rmoar@google.com \
--cc=brendan.higgins@linux.dev \
--cc=chaitanya.kumar.borah@intel.com \
--cc=davidgow@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jani.saarinen@intel.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=mripard@kernel.org \
--cc=rf@opensource.cirrus.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.