From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Vincent Abriou <vincent.abriou@st.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH v2 03/14] drm/sti: Remove pointless casts
Date: Tue, 9 Jul 2019 09:48:16 +0200 [thread overview]
Message-ID: <CA+M3ks4x85BQzYxKfqwtawUYfHV_0m5-USZd=zeaE4hRW-idWQ@mail.gmail.com> (raw)
In-Reply-To: <20190708162048.4286-4-ville.syrjala@linux.intel.com>
Le lun. 8 juil. 2019 à 18:21, Ville Syrjala
<ville.syrjala@linux.intel.com> a écrit :
>
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> There's no point in the cast for accessing the base class. Just
> take the address of the struct instead.
Applied on drm-misc-next,
Thanks,
Benjamin
>
> Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Cc: Vincent Abriou <vincent.abriou@st.com>
> Acked-by: Benjamin Gaignard <benjamin.gaignard@linaro.org>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/sti/sti_tvout.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_tvout.c b/drivers/gpu/drm/sti/sti_tvout.c
> index e1b3c8cb7287..42f4c264a783 100644
> --- a/drivers/gpu/drm/sti/sti_tvout.c
> +++ b/drivers/gpu/drm/sti/sti_tvout.c
> @@ -669,7 +669,7 @@ sti_tvout_create_dvo_encoder(struct drm_device *dev,
>
> encoder->tvout = tvout;
>
> - drm_encoder = (struct drm_encoder *)encoder;
> + drm_encoder = &encoder->encoder;
>
> drm_encoder->possible_crtcs = ENCODER_CRTC_MASK;
> drm_encoder->possible_clones = 1 << 0;
> @@ -722,7 +722,7 @@ static struct drm_encoder *sti_tvout_create_hda_encoder(struct drm_device *dev,
>
> encoder->tvout = tvout;
>
> - drm_encoder = (struct drm_encoder *) encoder;
> + drm_encoder = &encoder->encoder;
>
> drm_encoder->possible_crtcs = ENCODER_CRTC_MASK;
> drm_encoder->possible_clones = 1 << 0;
> @@ -771,7 +771,7 @@ static struct drm_encoder *sti_tvout_create_hdmi_encoder(struct drm_device *dev,
>
> encoder->tvout = tvout;
>
> - drm_encoder = (struct drm_encoder *) encoder;
> + drm_encoder = &encoder->encoder;
>
> drm_encoder->possible_crtcs = ENCODER_CRTC_MASK;
> drm_encoder->possible_clones = 1 << 1;
> --
> 2.21.0
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-07-09 7:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 16:20 [PATCH v2 00/14] drm: Try to fix encoder possible_clones/crtc Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 01/14] drm: Include the encoder itself in possible_clones Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 02/14] drm/gma500: Sanitize possible_clones Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 03/14] drm/sti: Remove pointless casts Ville Syrjala
2019-07-09 7:48 ` Benjamin Gaignard [this message]
2019-07-08 16:20 ` [PATCH v2 04/14] drm/sti: Try to fix up the tvout possible clones Ville Syrjala
2019-07-09 7:48 ` Benjamin Gaignard
2019-07-08 16:20 ` [PATCH v2 05/14] drm/exynos: Use drm_encoder_mask() Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 06/14] drm/imx: Remove the bogus possible_clones setup Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 07/14] drm/i915: Polish " Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 08/14] drm/i915: Populate possible_crtcs correctly Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 09/14] drm/i915: Fix DP-MST crtc_mask Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 10/14] drm/i915: Clean up encoder->crtc_mask setup Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 11/14] drm/i915: Simplfy LVDS crtc_mask setup Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 12/14] drm/i915: s/crtc_mask/pipe_mask/ Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 13/14] drm: Validate encoder->possible_clones Ville Syrjala
2019-07-08 16:20 ` [PATCH v2 14/14] drm: Validate encoder->possible_crtcs Ville Syrjala
2019-07-08 17:25 ` ✓ Fi.CI.BAT: success for drm: Try to fix encoder possible_clones/crtc Patchwork
2019-07-09 5:01 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+M3ks4x85BQzYxKfqwtawUYfHV_0m5-USZd=zeaE4hRW-idWQ@mail.gmail.com' \
--to=benjamin.gaignard@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.