From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Alexey Brodkin <abrodkin@synopsys.com>,
Liviu Dudau <liviu.dudau@arm.com>,
dri-devel@lists.freedesktop.org,
Vincent Abriou <vincent.abriou@st.com>,
Mali DP Maintainers <malidp@foss.arm.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 00/12] Cargo cult cleanup in atomic drivers
Date: Fri, 19 Jan 2018 16:00:35 +0100 [thread overview]
Message-ID: <CA+M3ks6EVXvf7RmYarB2prwhqfJu_fgG+ecaNfL+GArxN5+0qg@mail.gmail.com> (raw)
In-Reply-To: <20180117215535.16517-1-laurent.pinchart+renesas@ideasonboard.com>
2018-01-17 22:55 GMT+01:00 Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com>:
> Hello,
>
> This patch series removes a few cargo-cult constructs from a set of atomic
> drivers.
>
> Patches 01/12 and 02/12 remove the unneeded .mode_set() and .mode_set_base()
> CRTC handlers from the arc and atmel-hlcdc drivers.
>
> Patches 03/12 to 12/12 then remove the use of drm_plane_helper_disable() from
> the plane .destroy() handlers of atomic drivers, replacing them with the use
> of drm_atomic_helper_shutdown() at removal time. Interleaved there are patches
> 04/12 and 06/12 that remove unnecessary cleanups in error paths, and patch
> 09/12 that adds missing cleanup.
>
> All this has been compile-tested only.
Sorry but sti patches make the platform crash when removing display module.
Benjamin
>
> Laurent Pinchart (12):
> drm: arc: Don't set CRTC .mode_set and .mode_set_base handlers
> drm: atmel-hlcdc: Don't set CRTC .mode_set and .mode_set_base handlers
> drm: arc: Use drm_atomic_helper_shutdown() to disable planes on
> removal
> drm: arm: hdlcd: Don't destroy plane manually in hdlcd_setup_crtc()
> drm: arm: hdlcd: Use drm_atomic_helper_shutdown() to disable planes on
> removal
> drm: arm: malidp: Don't destroy planes manually in error handlers
> drm: arm: malidp: Use drm_atomic_helper_shutdown() to disable planes
> on removal
> drm: msm: Use drm_atomic_helper_shutdown() to disable planes on
> removal
> drm: sti: Cleanup KMS objects on removal
> drm: sti: Use drm_atomic_helper_shutdown() to disable planes on
> removal
> drm: vc4: Use drm_atomic_helper_shutdown() to disable planes on
> removal
> drm: zte: Use drm_atomic_helper_shutdown() to disable planes on
> removal
>
> drivers/gpu/drm/arc/arcpgu_crtc.c | 12 ++----------
> drivers/gpu/drm/arc/arcpgu_drv.c | 1 +
> drivers/gpu/drm/arm/hdlcd_crtc.c | 12 ++----------
> drivers/gpu/drm/arm/hdlcd_drv.c | 1 +
> drivers/gpu/drm/arm/malidp_crtc.c | 10 ++--------
> drivers/gpu/drm/arm/malidp_drv.c | 2 +-
> drivers/gpu/drm/arm/malidp_drv.h | 1 -
> drivers/gpu/drm/arm/malidp_planes.c | 17 +----------------
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 --
> drivers/gpu/drm/msm/Kconfig | 1 -
> drivers/gpu/drm/msm/mdp/mdp4/mdp4_plane.c | 1 -
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 1 -
> drivers/gpu/drm/msm/msm_drv.c | 1 +
> drivers/gpu/drm/sti/sti_cursor.c | 10 +---------
> drivers/gpu/drm/sti/sti_drv.c | 2 ++
> drivers/gpu/drm/sti/sti_gdp.c | 10 +---------
> drivers/gpu/drm/sti/sti_hqvdp.c | 10 +---------
> drivers/gpu/drm/vc4/Kconfig | 1 -
> drivers/gpu/drm/vc4/vc4_drv.c | 3 +++
> drivers/gpu/drm/vc4/vc4_plane.c | 8 +-------
> drivers/gpu/drm/zte/Kconfig | 2 +-
> drivers/gpu/drm/zte/zx_drm_drv.c | 1 +
> drivers/gpu/drm/zte/zx_plane.c | 8 +-------
> 23 files changed, 23 insertions(+), 94 deletions(-)
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Benjamin Gaignard
Graphic Study Group
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-01-19 15:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 21:55 [PATCH 00/12] Cargo cult cleanup in atomic drivers Laurent Pinchart
2018-01-17 21:55 ` [PATCH 01/12] drm: arc: Don't set CRTC .mode_set and .mode_set_base handlers Laurent Pinchart
2018-01-17 21:55 ` [PATCH 02/12] drm: atmel-hlcdc: " Laurent Pinchart
2018-01-18 8:44 ` Boris Brezillon
2018-01-17 21:55 ` [PATCH 03/12] drm: arc: Use drm_atomic_helper_shutdown() to disable planes on removal Laurent Pinchart
2018-01-17 21:55 ` [PATCH 04/12] drm: arm: hdlcd: Don't destroy plane manually in hdlcd_setup_crtc() Laurent Pinchart
2018-01-17 21:55 ` [PATCH 05/12] drm: arm: hdlcd: Use drm_atomic_helper_shutdown() to disable planes on removal Laurent Pinchart
2018-01-17 21:55 ` [PATCH 06/12] drm: arm: malidp: Don't destroy planes manually in error handlers Laurent Pinchart
2018-01-17 21:55 ` [PATCH 07/12] drm: arm: malidp: Use drm_atomic_helper_shutdown() to disable planes on removal Laurent Pinchart
2018-01-19 15:48 ` Liviu Dudau
2018-01-17 21:55 ` [PATCH 08/12] drm: msm: " Laurent Pinchart
2018-01-19 4:51 ` Archit Taneja
2018-01-17 21:55 ` [PATCH 09/12] drm: sti: Cleanup KMS objects " Laurent Pinchart
2018-01-17 21:55 ` [PATCH 10/12] drm: sti: Use drm_atomic_helper_shutdown() to disable planes " Laurent Pinchart
2018-01-17 21:55 ` [PATCH 11/12] drm: vc4: " Laurent Pinchart
2018-01-18 5:44 ` Eric Anholt
2018-01-20 11:54 ` kbuild test robot
2018-01-20 12:03 ` kbuild test robot
2018-01-17 21:55 ` [PATCH 12/12] drm: zte: " Laurent Pinchart
2018-02-02 7:48 ` Shawn Guo
2018-01-18 17:32 ` [PATCH 00/12] Cargo cult cleanup in atomic drivers Liviu Dudau
2018-01-18 18:00 ` Alexey Brodkin
2018-01-19 15:00 ` Benjamin Gaignard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+M3ks6EVXvf7RmYarB2prwhqfJu_fgG+ecaNfL+GArxN5+0qg@mail.gmail.com \
--to=benjamin.gaignard@linaro.org \
--cc=abrodkin@synopsys.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=liviu.dudau@arm.com \
--cc=malidp@foss.arm.com \
--cc=shawnguo@kernel.org \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.