From: Tzung-Bi Shih <tzungbi@google.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Arnd Bergmann <arnd@arndb.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Eric Biggers <ebiggers@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
Mark Brown <broonie@kernel.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH v2] ASoC: cros_ec_codec: switch to library API for SHA-256
Date: Fri, 15 May 2020 18:16:26 +0800 [thread overview]
Message-ID: <CA+Px+wUpYaUfA1saEWePuy+CmCX8mPiH+-Mg23P6c+jhM_yxHQ@mail.gmail.com> (raw)
In-Reply-To: <20200515100309.20795-1-ardb@kernel.org>
On Fri, May 15, 2020 at 6:03 PM Ard Biesheuvel <ardb@kernel.org> wrote:
>
> The CrOS EC codec driver uses SHA-256 explicitly, and not in a
> performance critical manner, so there is really no point in using
> the SHASH crypto API here. Let's switch to the library API instead.
>
> Cc: Cheng-Yi Chiang <cychiang@chromium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Liam Girdwood <lgirdwood@gmail.com>
> Cc: Mark Brown <broonie@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Eric Biggers <ebiggers@kernel.org>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: Tzung-Bi Shih <tzungbi@google.com>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
next prev parent reply other threads:[~2020-05-15 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 10:03 [PATCH v2] ASoC: cros_ec_codec: switch to library API for SHA-256 Ard Biesheuvel
2020-05-15 10:16 ` Tzung-Bi Shih [this message]
2020-05-15 11:10 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+Px+wUpYaUfA1saEWePuy+CmCX8mPiH+-Mg23P6c+jhM_yxHQ@mail.gmail.com \
--to=tzungbi@google.com \
--cc=alsa-devel@alsa-project.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=ebiggers@kernel.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=herbert@gondor.apana.org.au \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.