From: Alexandru Ardelean <ardeleanalex@gmail.com>
To: Pekka Korpinen <pekka.korpinen@iki.fi>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: dac: ad5446: Fix ad5622_write() return value
Date: Wed, 29 Sep 2021 12:46:02 +0300 [thread overview]
Message-ID: <CA+U=DspS04Crdr7OwfrTuBueTYOA+rV9sS0_mB-Q9+hsoufxKw@mail.gmail.com> (raw)
In-Reply-To: <20210928195548.17846-1-pekka.korpinen@iki.fi>
On Tue, Sep 28, 2021 at 10:57 PM Pekka Korpinen <pekka.korpinen@iki.fi> wrote:
>
> On success i2c_master_send() returns the number of bytes written. The
> call from iio_write_channel_info(), however, expects the return value to
> be zero on success.
>
Requires a Fixes tag.
But other than that:
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
> Signed-off-by: Pekka Korpinen <pekka.korpinen@iki.fi>
> ---
> This bug causes incorrect consumption of the sysfs buffer in
> iio_write_channel_info(). When writing more than two characters to
> out_voltage0_raw, the ad5446 write handler is called multiple times
> causing unexpected behavior.
>
> A similar fix was applied for ad5064.c in 2015 - commit 03fe472ef33b
> ("iio:ad5064: Make sure ad5064_i2c_write() returns 0 on success").
>
> drivers/iio/dac/ad5446.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/dac/ad5446.c b/drivers/iio/dac/ad5446.c
> index 488ec69967d6..dfd541bbde5b 100644
> --- a/drivers/iio/dac/ad5446.c
> +++ b/drivers/iio/dac/ad5446.c
> @@ -531,8 +531,13 @@ static int ad5622_write(struct ad5446_state *st, unsigned val)
> {
> struct i2c_client *client = to_i2c_client(st->dev);
> __be16 data = cpu_to_be16(val);
> + int ret;
> +
> + ret = i2c_master_send(client, (char *)&data, sizeof(data));
> + if (ret < 0)
> + return ret;
>
> - return i2c_master_send(client, (char *)&data, sizeof(data));
> + return 0;
> }
>
> /*
> --
> 2.33.0
>
next prev parent reply other threads:[~2021-09-29 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 19:55 [PATCH] iio: dac: ad5446: Fix ad5622_write() return value Pekka Korpinen
2021-09-29 9:46 ` Alexandru Ardelean [this message]
2021-09-29 9:59 ` Lars-Peter Clausen
2021-09-29 18:57 ` [PATCH v2] " Pekka Korpinen
2021-10-17 10:43 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+U=DspS04Crdr7OwfrTuBueTYOA+rV9sS0_mB-Q9+hsoufxKw@mail.gmail.com' \
--to=ardeleanalex@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pekka.korpinen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.