From: Peng Tao <bergwolf@gmail.com>
To: "Myklebust, Trond" <Trond.Myklebust@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"Adamson, Andy" <William.Adamson@netapp.com>
Subject: Re: [PATCH 1/2] NFSv41: fix DIO write_io calculation
Date: Thu, 9 Aug 2012 22:31:45 +0800 [thread overview]
Message-ID: <CA+a=Yy723Ss3mdWwD=MA8dbPHvnRr0=qBTKag-GcPL5mPdh-uw@mail.gmail.com> (raw)
In-Reply-To: <1344522340.23523.0.camel@lade.trondhjem.org>
On Thu, Aug 9, 2012 at 10:25 PM, Myklebust, Trond
<Trond.Myklebust@netapp.com> wrote:
> On Thu, 2012-08-09 at 10:36 +0800, Peng Tao wrote:
>> On Thu, Aug 9, 2012 at 3:03 AM, Myklebust, Trond
>> <Trond.Myklebust@netapp.com> wrote:
>> > On Wed, 2012-08-08 at 09:49 +0800, Peng Tao wrote:
>> >> pnfs_within_mdsthreshold() is called inside pg_init. We need
>> >> to set read_io/write_io before that.
>> >
>> > Why?
>> If we don't set read_io/write_io before calling pg_init, we fail
>> pnfs_within_mdsthreshold() and IO goes to MDS.
>> A simple test case:
>> dd if=foo of=/mnt/pnfs/bar bs=10M count=1 oflag=direct
>>
>
> My point was that this explanation needs to go into the changelog of the
> commit.
OK. Will resend the patch with proper changelog.
--
Thanks,
Tao
prev parent reply other threads:[~2012-08-09 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-08 1:49 [PATCH 1/2] NFSv41: fix DIO write_io calculation Peng Tao
2012-08-08 1:49 ` [PATCH 2/2] NFS41: fix error of setting blocklayoutdriver Peng Tao
2012-08-08 12:49 ` Bryan Schumaker
2012-08-08 14:48 ` Peng Tao
2012-08-08 19:03 ` [PATCH 1/2] NFSv41: fix DIO write_io calculation Myklebust, Trond
2012-08-09 2:36 ` Peng Tao
2012-08-09 14:25 ` Myklebust, Trond
2012-08-09 14:31 ` Peng Tao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+a=Yy723Ss3mdWwD=MA8dbPHvnRr0=qBTKag-GcPL5mPdh-uw@mail.gmail.com' \
--to=bergwolf@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=William.Adamson@netapp.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.