Re: [PATCH 02/13] drm/i915/skl: Make sure to break when not finding suitable PLL dividers

From: Paulo Zanoni <przanoni@gmail.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 02/13] drm/i915/skl: Make sure to break when not finding suitable PLL dividers
Date: Wed, 27 May 2015 14:58:10 -0300	[thread overview]
Message-ID: <CA+gsUGQ6aGTtRxcQtDUsCtiZV2eQ+KogN=qbbSo+6GxC_PoBJg@mail.gmail.com> (raw)
In-Reply-To: <1431020329-11414-3-git-send-email-damien.lespiau@intel.com>

2015-05-07 14:38 GMT-03:00 Damien Lespiau <damien.lespiau@intel.com>:
> Right now, when finishing the cycle with odd dividers without finding a
> suitable candidate, we end up in an infinite loop. Make sure to break in
> that case.

Cc stable?

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

>
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 2e24fa4..da7aa0f 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1180,6 +1180,10 @@ found:
>                 }
>
>                 if (min_dco_index > 2 && dco_count == 2) {
> +                        /* oh well, we tried... */
> +                        if (retry_with_odd)
> +                                break;
> +
>                         retry_with_odd = true;
>                         dco_count = 0;
>                 }
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx