From: "Ausmus, James" <james.ausmus@intel.com>
To: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Intel GFX <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 8/9] drm/i915/dp: Protect link training with connection mutex
Date: Thu, 14 Sep 2017 15:26:37 -0700 [thread overview]
Message-ID: <CAA1Hj7Ruy=RamBe4VjA5JkWvdow8yBNfW1RE7xzh5HMTXBgHpg@mail.gmail.com> (raw)
In-Reply-To: <20170912235730.3492-8-dhinakaran.pandiyan@intel.com>
On Tue, Sep 12, 2017 at 4:57 PM, Dhinakaran Pandiyan
<dhinakaran.pandiyan@intel.com> wrote:
> The other instances of link training are protected with
> connection_mutex, so do the same in check_mst_status() too.
We don't seem to be taking connection_mutex around
intel_dp_start/stop_link_train in the intel_enable_dp or
intel_ddi_pre_enable_dp paths (unless it's taken higher in the stack)
- is it needed in all instances?
>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index aab9ba31f79e..644463ba313e 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4191,6 +4191,7 @@ static void intel_dp_handle_test_request(struct intel_dp *intel_dp)
> static int
> intel_dp_check_mst_status(struct intel_dp *intel_dp)
> {
> + struct drm_device *dev = intel_dp_to_dev(intel_dp);
> bool bret;
> u8 esi[DP_DPRX_ESI_LEN] = { 0 };
> int ret = 0;
> @@ -4205,8 +4206,11 @@ intel_dp_check_mst_status(struct intel_dp *intel_dp)
> if (intel_dp->active_mst_links &&
> !drm_dp_channel_eq_ok(&esi[10], intel_dp->lane_count)) {
> DRM_DEBUG_KMS("channel EQ not ok, retraining\n");
> +
> + drm_modeset_lock(&dev->mode_config.connection_mutex, NULL);
> intel_dp_start_link_train(intel_dp);
> intel_dp_stop_link_train(intel_dp);
> + drm_modeset_unlock(&dev->mode_config.connection_mutex);
> }
>
> DRM_DEBUG_KMS("got esi %3ph\n", esi);
> --
> 2.11.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
James Ausmus
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-14 22:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 23:57 [PATCH 1/9] drm/i915/mst: Debug log connector name in destroy_connector() Dhinakaran Pandiyan
2017-09-12 23:57 ` [PATCH 2/9] drm/i915/mst: Print active mst links after update Dhinakaran Pandiyan
2017-09-14 20:58 ` Ausmus, James
2017-09-12 23:57 ` [PATCH 3/9] drm/i915/dp: Fix buffer size for sink_irq_esi read Dhinakaran Pandiyan
2017-09-14 21:10 ` Ausmus, James
2017-09-12 23:57 ` [PATCH 4/9] drm/i915/dp: Avoid more dpcd transactions after resume failure Dhinakaran Pandiyan
2017-09-13 13:24 ` Ville Syrjälä
2017-09-13 20:21 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 5/9] drm/i915/dp: Remove intel_dp->is_mst check in intel_dp_check_mst_status Dhinakaran Pandiyan
2017-09-13 9:32 ` Jani Nikula
2017-09-13 20:13 ` Pandiyan, Dhinakaran
2017-09-13 13:31 ` Ville Syrjälä
2017-09-13 20:33 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 6/9] drm/i915/dp: Handle check_mst_status() failure in one place Dhinakaran Pandiyan
2017-09-14 21:32 ` Ausmus, James
2017-09-14 21:52 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 7/9] drm/i915/dp: Avoid double-printing esi regs Dhinakaran Pandiyan
2017-09-14 20:42 ` Ausmus, James
2017-09-12 23:57 ` [PATCH 8/9] drm/i915/dp: Protect link training with connection mutex Dhinakaran Pandiyan
2017-09-14 22:26 ` Ausmus, James [this message]
2017-09-15 18:16 ` Pandiyan, Dhinakaran
2017-09-15 18:38 ` Manasi Navare
2017-09-15 18:57 ` Ausmus, James
2017-09-15 10:10 ` Ville Syrjälä
2017-09-18 21:50 ` Pandiyan, Dhinakaran
2017-09-19 12:42 ` Ville Syrjälä
2017-09-19 19:21 ` Pandiyan, Dhinakaran
2017-09-12 23:57 ` [PATCH 9/9] drm/i915/dp: Remove redundant can_mst checks in intel_dp_configure_mst() Dhinakaran Pandiyan
2017-09-14 22:36 ` Ausmus, James
2017-09-15 18:29 ` Pandiyan, Dhinakaran
2017-09-13 0:19 ` ✗ Fi.CI.BAT: failure for series starting with [1/9] drm/i915/mst: Debug log connector name in destroy_connector() Patchwork
2017-09-14 0:20 ` [PATCH 1/9] " Ausmus, James
2017-09-14 19:22 ` Pandiyan, Dhinakaran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA1Hj7Ruy=RamBe4VjA5JkWvdow8yBNfW1RE7xzh5HMTXBgHpg@mail.gmail.com' \
--to=james.ausmus@intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.