From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: John Fastabend <john.fastabend@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf] selftests/bpf: prevent runqslower from racing on building bpftool
Date: Thu, 6 Aug 2020 16:38:27 -0700 [thread overview]
Message-ID: <CAADnVQJPqWKS7-4f2G=-h2D1OwLZg1C1SRggXuYXg0rEg9JCBg@mail.gmail.com> (raw)
In-Reply-To: <5f2ba2b6a22ac_291f2b27e574e5b885@john-XPS-13-9370.notmuch>
On Wed, Aug 5, 2020 at 11:27 PM John Fastabend <john.fastabend@gmail.com> wrote:
>
> Andrii Nakryiko wrote:
> > runqslower's Makefile is building/installing bpftool into
> > $(OUTPUT)/sbin/bpftool, which coincides with $(DEFAULT_BPFTOOL). In practice
> > this means that often when building selftests from scratch (after `make
> > clean`), selftests are racing with runqslower to simultaneously build bpftool
> > and one of the two processes fail due to file being busy. Prevent this race by
> > explicitly order-depending on $(BPFTOOL_DEFAULT).
> >
> > Fixes: a2c9652f751e ("selftests: Refactor build to remove tools/lib/bpf from include path")
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> > ---
>
> Acked-by: John Fastabend <john.fastabend@gmail.com>
Applied. Thanks
prev parent reply other threads:[~2020-08-06 23:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 0:47 [PATCH bpf] selftests/bpf: prevent runqslower from racing on building bpftool Andrii Nakryiko
2020-08-06 6:27 ` John Fastabend
2020-08-06 23:38 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQJPqWKS7-4f2G=-h2D1OwLZg1C1SRggXuYXg0rEg9JCBg@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.