All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Lorenz Bauer <lmb@cloudflare.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	kernel-team <kernel-team@cloudflare.com>,
	Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 0/5] PROG_TEST_RUN support for sk_lookup programs
Date: Fri, 26 Feb 2021 12:55:01 -0800	[thread overview]
Message-ID: <CAADnVQJi_==XB8=PdqfOa24HfSAcyaasnbZCzxvbcOtCWaP7EQ@mail.gmail.com> (raw)
In-Reply-To: <20210226103103.131210-1-lmb@cloudflare.com>

On Fri, Feb 26, 2021 at 2:31 AM Lorenz Bauer <lmb@cloudflare.com> wrote:
>
> We don't have PROG_TEST_RUN support for sk_lookup programs at the
> moment. So far this hasn't been a problem, since we can run our
> tests in a separate network namespace. For benchmarking it's nice
> to have PROG_TEST_RUN, so I've gone and implemented it.
>
> Based on discussion on the v1 I've dropped support for testing multiple
> programs at once.
>
> Changes since v1:
> - Add sparse annotations to the t_* functions
> - Add appropriate type casts in bpf_prog_test_run_sk_lookup
> - Drop running multiple programs

Looks good.
I applied it, but then reverted since test_verifier needs to be adjusted:
./test_verifier 349
#349/p valid 1,2,4,8-byte reads from bpf_sk_lookup FAIL: Unexpected
bpf_prog_test_run error (Invalid argument) (run 1/1)

That's the only test that has ACCEPT for sk_lookup prog type
and the framework now is trying to run it.
Pls respin.

      parent reply	other threads:[~2021-02-26 20:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 10:30 [PATCH bpf-next v2 0/5] PROG_TEST_RUN support for sk_lookup programs Lorenz Bauer
2021-02-26 10:31 ` [PATCH bpf-next v2 1/4] bpf: consolidate shared test timing code Lorenz Bauer
2021-02-26 10:31 ` [PATCH bpf-next v2 2/4] bpf: add PROG_TEST_RUN support for sk_lookup programs Lorenz Bauer
2021-02-26 10:31 ` [PATCH bpf-next v2 3/4] selftests: bpf: convert sk_lookup ctx access tests to PROG_TEST_RUN Lorenz Bauer
2021-02-26 10:31 ` [PATCH bpf-next v2 4/4] selftests: bpf: check that PROG_TEST_RUN repeats as requested Lorenz Bauer
2021-02-26 20:55 ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAADnVQJi_==XB8=PdqfOa24HfSAcyaasnbZCzxvbcOtCWaP7EQ@mail.gmail.com' \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@cloudflare.com \
    --cc=lmb@cloudflare.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.