From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Dmitrii Banshchikov <me@ubique.spb.ru>
Cc: Gary Lin <glin@suse.com>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Martin Loviska <mloviska@suse.com>
Subject: Re: [PATCH bpf] net/bpfilter: specify the log level for the kmsg message
Date: Thu, 24 Jun 2021 20:47:06 -0700 [thread overview]
Message-ID: <CAADnVQK2uQ3MvwaRztMtcw8SJz1r213hxA+vM2dCtr6RfpZnSA@mail.gmail.com> (raw)
In-Reply-To: <20210623065744.igawwy424y2zy26t@amnesia>
On Tue, Jun 22, 2021 at 11:57 PM Dmitrii Banshchikov <me@ubique.spb.ru> wrote:
>
> On Tue, Jun 22, 2021 at 09:38:38PM -0700, Alexei Starovoitov wrote:
> > On Tue, Jun 22, 2021 at 9:09 PM Gary Lin <glin@suse.com> wrote:
> > >
> > > Per the kmsg document(*), if we don't specify the log level with a
> > > prefix "<N>" in the message string, the default log level will be
> > > applied to the message. Since the default level could be warning(4),
> > > this would make the log utility such as journalctl treat the message,
> > > "Started bpfilter", as a warning. To avoid confusion, this commit adds
> > > the prefix "<5>" to make the message always a notice.
> > >
> > > (*) https://www.kernel.org/doc/Documentation/ABI/testing/dev-kmsg
> > >
> > > Fixes: 36c4357c63f3 ("net: bpfilter: print umh messages to /dev/kmsg")
> > > Reported-by: Martin Loviska <mloviska@suse.com>
> > > Signed-off-by: Gary Lin <glin@suse.com>
> > > ---
> > > net/bpfilter/main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c
> > > index 05e1cfc1e5cd..291a92546246 100644
> > > --- a/net/bpfilter/main.c
> > > +++ b/net/bpfilter/main.c
> > > @@ -57,7 +57,7 @@ int main(void)
> > > {
> > > debug_f = fopen("/dev/kmsg", "w");
> > > setvbuf(debug_f, 0, _IOLBF, 0);
> > > - fprintf(debug_f, "Started bpfilter\n");
> > > + fprintf(debug_f, "<5>Started bpfilter\n");
> > > loop();
> > > fclose(debug_f);
> > > return 0;
> >
> > Adding Dmitrii who is redesigning the whole bpfilter.
>
> Thanks. The same logic already exists in the bpfilter v1 patchset
> - [1].
>
> 1. https://lore.kernel.org/bpf/c72bac57-84a0-ac4c-8bd8-08758715118e@fb.com/T/#mb36e20c4e5e4a70746bd50a109b1630687990214
Dmitrii,
what do you prefer we should do with this patch then?
next prev parent reply other threads:[~2021-06-25 3:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 4:09 [PATCH bpf] net/bpfilter: specify the log level for the kmsg message Gary Lin
2021-06-23 4:38 ` Alexei Starovoitov
2021-06-23 6:57 ` Dmitrii Banshchikov
2021-06-25 3:47 ` Alexei Starovoitov [this message]
2021-06-25 7:36 ` Dmitrii Banshchikov
2021-06-25 11:16 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQK2uQ3MvwaRztMtcw8SJz1r213hxA+vM2dCtr6RfpZnSA@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=glin@suse.com \
--cc=me@ubique.spb.ru \
--cc=mloviska@suse.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.