From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Kenny Yu <kennyyu@fb.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Andrii Nakryiko <andrii@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, bpf <bpf@vger.kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Gabriele <phoenix1987@gmail.com>, Yonghong Song <yhs@fb.com>
Subject: Re: [PATCH v5 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper
Date: Fri, 21 Jan 2022 09:47:13 -0800 [thread overview]
Message-ID: <CAADnVQKZa_rm3sybP=Rt4Nm-zYrv4s9XvF7PGDFTOBD-TDu23g@mail.gmail.com> (raw)
In-Reply-To: <20220121174145.3433628-1-kennyyu@fb.com>
On Fri, Jan 21, 2022 at 9:42 AM Kenny Yu <kennyyu@fb.com> wrote:
>
> Thanks for the suggestions! I'll go with the all-or-nothing approach to
> be consistent with `bpf_copy_from_user` and will make the following changes:
>
> * Return value: returns 0 on success, or negative error on failure.
> * If we had a partial read, we will memset the read bytes to 0 and return
> -EFAULT
Not read bytes, but all bytes.
copy_from_user zeros leftover for us, but access_process_vm doesn't
do this on partial read.
next prev parent reply other threads:[~2022-01-21 17:47 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 23:31 [PATCH bpf-next 0/3] Add bpf_access_process_vm helper and sleepable bpf iterator programs Kenny Yu
2022-01-13 23:31 ` [PATCH bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-13 23:31 ` [PATCH bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-13 23:31 ` [PATCH bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 0/4] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 1/4] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 2/4] bpf: Add support for sleepable programs in bpf_iter_run_prog Kenny Yu
2022-01-14 2:50 ` Alexei Starovoitov
2022-01-14 23:15 ` Kenny Yu
2022-01-14 0:48 ` [PATCH v2 bpf-next 3/4] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-14 0:49 ` [PATCH v2 bpf-next 4/4] selftests/bpf: Add test " Kenny Yu
2022-01-14 2:39 ` Alexei Starovoitov
2022-01-14 23:14 ` Kenny Yu
2022-01-15 1:38 ` Andrii Nakryiko
2022-01-15 4:30 ` Kenny Yu
2022-01-15 16:27 ` Gabriele
2022-01-19 16:56 ` Kenny Yu
2022-01-19 18:02 ` [PATCH v3 bpf-next 0/3] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-19 18:02 ` [PATCH v3 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-19 20:16 ` Alexei Starovoitov
2022-01-19 22:51 ` Kenny Yu
2022-01-19 18:02 ` [PATCH v3 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-19 18:02 ` [PATCH v3 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 0/3] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-20 3:45 ` Yonghong Song
2022-01-20 17:11 ` Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-19 22:59 ` [PATCH v4 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 0/3] Add bpf_access_process_vm helper and " Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 1/3] bpf: Add bpf_access_process_vm() helper Kenny Yu
2022-01-20 22:45 ` Andrii Nakryiko
2022-01-21 2:27 ` Alexei Starovoitov
2022-01-21 17:20 ` Andrii Nakryiko
2022-01-21 17:41 ` Kenny Yu
2022-01-21 17:47 ` Alexei Starovoitov [this message]
2022-01-21 18:30 ` Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-20 17:29 ` [PATCH v5 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-20 22:48 ` Andrii Nakryiko
2022-01-21 19:30 ` [PATCH v6 bpf-next 0/3] Add bpf_copy_from_user_task helper and " Kenny Yu
2022-01-21 19:30 ` [PATCH v6 bpf-next 1/3] bpf: Add bpf_copy_from_user_task() helper Kenny Yu
2022-01-21 19:53 ` Andrii Nakryiko
2022-01-21 20:04 ` Yonghong Song
2022-01-21 20:07 ` Andrii Nakryiko
2022-01-21 21:15 ` Yonghong Song
2022-01-24 17:30 ` Kenny Yu
2022-01-22 9:58 ` Gabriele
2022-01-22 10:08 ` Gabriele
2022-01-21 19:30 ` [PATCH v6 bpf-next 2/3] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-21 19:54 ` Andrii Nakryiko
2022-01-21 19:30 ` [PATCH v6 bpf-next 3/3] selftests/bpf: Add test " Kenny Yu
2022-01-21 19:55 ` Andrii Nakryiko
2022-01-24 18:53 ` [PATCH v7 bpf-next 0/4] Add bpf_copy_from_user_task helper and " Kenny Yu
2022-01-24 18:54 ` [PATCH v7 bpf-next 1/4] bpf: Add support for bpf iterator programs to use sleepable helpers Kenny Yu
2022-01-24 22:19 ` Andrii Nakryiko
2022-01-24 18:54 ` [PATCH v7 bpf-next 2/4] bpf: Add bpf_copy_from_user_task() helper Kenny Yu
2022-01-24 22:18 ` Andrii Nakryiko
2022-01-25 4:06 ` Alexei Starovoitov
2022-01-24 18:54 ` [PATCH v7 bpf-next 3/4] libbpf: Add "iter.s" section for sleepable bpf iterator programs Kenny Yu
2022-01-24 18:54 ` [PATCH v7 bpf-next 4/4] selftests/bpf: Add test " Kenny Yu
2022-01-25 4:10 ` [PATCH v7 bpf-next 0/4] Add bpf_copy_from_user_task helper and " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQKZa_rm3sybP=Rt4Nm-zYrv4s9XvF7PGDFTOBD-TDu23g@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kennyyu@fb.com \
--cc=phoenix1987@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.