All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf <bpf@vger.kernel.org>,
	Network Development <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] tools/runqslower: ensure own vmlinux.h is picked up first
Date: Fri, 24 Apr 2020 17:46:31 -0700	[thread overview]
Message-ID: <CAADnVQL6Q5KCiUed2ckP=9kmW8ogoCoSyUU4G96Z7SCku_ngug@mail.gmail.com> (raw)
In-Reply-To: <20200422012407.176303-1-andriin@fb.com>

On Tue, Apr 21, 2020 at 6:24 PM Andrii Nakryiko <andriin@fb.com> wrote:
>
> Reorder include paths to ensure that runqslower sources are picking up
> vmlinux.h, generated by runqslower's own Makefile. When runqslower is built
> from selftests/bpf, due to current -I$(BPF_INCLUDE) -I$(OUTPUT) ordering, it
> might pick up not-yet-complete vmlinux.h, generated by selftests Makefile,
> which could lead to compilation errors like [0]. So ensure that -I$(OUTPUT)
> goes first and rely on runqslower's Makefile own dependency chain to ensure
> vmlinux.h is properly completed before source code relying on it is compiled.
>
>   [0] https://travis-ci.org/github/libbpf/libbpf/jobs/677905925
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>

Applied to bpf tree. Thanks

      reply	other threads:[~2020-04-25  0:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-22  1:24 [PATCH bpf-next] tools/runqslower: ensure own vmlinux.h is picked up first Andrii Nakryiko
2020-04-25  0:46 ` Alexei Starovoitov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAADnVQL6Q5KCiUed2ckP=9kmW8ogoCoSyUU4G96Z7SCku_ngug@mail.gmail.com' \
    --to=alexei.starovoitov@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.