Re: [PATCH bpf-next] bpf: add bpf_jit_blinding_enabled for !CONFIG_BPF_JIT

From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Jakub Sitnicki <jakub@cloudflare.com>,
	Andrii Nakryiko <andrii.nakryiko@gmail.com>,
	Network Development <netdev@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH bpf-next] bpf: add bpf_jit_blinding_enabled for !CONFIG_BPF_JIT
Date: Sat, 23 Nov 2019 13:04:26 -0800	[thread overview]
Message-ID: <CAADnVQLkMH6NY8phOemtQSF3Y-D4s6k-f34wz6Edq2NjdY+bWg@mail.gmail.com> (raw)
In-Reply-To: <40baf8f3507cac4851a310578edfb98ce73b5605.1574541375.git.daniel@iogearbox.net>

On Sat, Nov 23, 2019 at 12:37 PM Daniel Borkmann <daniel@iogearbox.net> wrote:
>
> Add a definition of bpf_jit_blinding_enabled() when CONFIG_BPF_JIT is not set
> in order to fix a recent build regression:
>
>   [...]
>   CC      kernel/bpf/verifier.o
>   CC      kernel/bpf/inode.o
> kernel/bpf/verifier.c: In function ‘fixup_bpf_calls’:
> kernel/bpf/verifier.c:9132:25: error: implicit declaration of function ‘bpf_jit_blinding_enabled’; did you mean ‘bpf_jit_kallsyms_enabled’? [-Werror=implicit-function-declaration]
>  9132 |  bool expect_blinding = bpf_jit_blinding_enabled(prog);
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~~
>       |                         bpf_jit_kallsyms_enabled
>   CC      kernel/bpf/helpers.o
>   CC      kernel/bpf/hashtab.o
>   [...]
>
> Fixes: bad63c9ea554 ("bpf: Constant map key tracking for prog array pokes")
> Reported-by: Jakub Sitnicki <jakub@cloudflare.com>
> Reported-by: Andrii Nakryiko <andriin@fb.com>
> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

Applied. Thanks