Re: [PATCH 5/8] drivers: media: coda: fix warning same module names

From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
	"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
	David Airlie <airlied@linux.ie>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Lee Jones <lee.jones@linaro.org>, "marex@denx.de" <marex@denx.de>,
	"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
	"vivien.didelot@gmail.com" <vivien.didelot@gmail.com>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	"b.zolnierkie@samsung.com" <b.zolnierkie@samsung.com>,
	Mark Brown <broonie@kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Networking <netdev@vger.kernel.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Matt Redfearn <matt.redfearn@thinci.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	David Miller <davem@davemloft.net>,
	hka
Subject: Re: [PATCH 5/8] drivers: media: coda: fix warning same module names
Date: Tue, 11 Jun 2019 13:18:12 -0300	[thread overview]
Message-ID: <CAAEAJfC9vja5WwsNc5+MTVHLFg_P3zG=OZt_CuRR5eG-3iWD9Q@mail.gmail.com> (raw)
In-Reply-To: <CADYN=9K7GwPGM_Eh5q-OZ9rcEPAjXw4BXy-m3a=QxmGuVruCUw@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 2618 bytes --]

On Tue, Jun 11, 2019, 1:01 PM Anders Roxell <anders.roxell@linaro.org>
wrote:

> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> >
> > On 6/11/19 10:15 AM, Philipp Zabel wrote:
> > > Hi,
> > >
> > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote:
> > >>
> > >> On 10/06/2019 14:03, Anders Roxell wrote:
> > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl>
> wrote:
> > >>>>
> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote:
> > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as
> > >>>>> loadable modules, we see the following warning:
> > >>>>>
> > >>>>> warning: same module names found:
> > >>>>>    fs/coda/coda.ko
> > >>>>>    drivers/media/platform/coda/coda.ko
> > >>>>>
> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS
> as is
> > >>>>> since thats a well known module.
> > >>>>>
> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> > >>>>> ---
> > >>>>>   drivers/media/platform/coda/Makefile | 4 ++--
> > >>>>>   1 file changed, 2 insertions(+), 2 deletions(-)
> > >>>>>
> > >>>>> diff --git a/drivers/media/platform/coda/Makefile
> b/drivers/media/platform/coda/Makefile
> > >>>>> index 54e9a73a92ab..588e6bf7c190 100644
> > >>>>> --- a/drivers/media/platform/coda/Makefile
> > >>>>> +++ b/drivers/media/platform/coda/Makefile
> > >>>>> @@ -1,6 +1,6 @@
> > >>>>>   # SPDX-License-Identifier: GPL-2.0-only
> > >>>>>
> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o
> coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o
> coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o
> > >>>>>
> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o
> > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o
> > >>>>
> > >>>> How about imx-coda? video-coda suggests it is part of the video
> subsystem,
> > >>>> which it isn't.
> > >>>
> > >>> I'll resend a v2 shortly with imx-coda instead.
> > >
> > > I'd be in favor of calling it "coda-vpu" instead.
> >
> > Fine by me!
> >
> > >
> > >> What about other vendor SoCs implementing the Coda IP block which are
> > >> not an imx? I'd prefer a more generic name - maybe media-coda.
> > >
> > > Right, this driver can be used on other SoCs [1].
> >
> > Good point.
>
> OK, so I'll change it to 'media-coda'.
>
>
>
>
As suggested by Philipp, coda-vpu seems the most accurate name.

Thanks,
Ezequiel

Cheers,
> Anders
>
> >
> > Regards,
> >
> >         Hans
> >
> > >
> > > [1]
> https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html
> > >
> > > regards
> > > Philipp
> > >
> >
>

[-- Attachment #1.2: Type: text/html, Size: 4725 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel