From: InKi Dae <inki.dae@samsung.com>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: kyungmin.park@samsung.com, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 05/13] drm/exynos: removed exynos_drm_encoder_dpms call
Date: Mon, 20 Aug 2012 11:00:20 +0900 [thread overview]
Message-ID: <CAAQKjZMHzORsVyvSYtux+QX_u-+jkRyiER-txg=ny8Aq6+CVuA@mail.gmail.com> (raw)
In-Reply-To: <50318F69.40307@samsung.com>
2012/8/20 Joonyoung Shim <jy0922.shim@samsung.com>:
> On 08/17/2012 06:50 PM, Inki Dae wrote:
>>
>> encoder's mode_set callback isn't specific to hardware so it doesn't
>> need to call exynos_drm_encoder_dpms().
>
>
> Then, where is exynos_drm_encoder_dpms() called?
>
with this patch series, exynos_drm_encoder_dpms() will call apply
callback to set local overlay data to real hardware registers and
exynos_drm_crtc_dpms() will be used to enable/disable fimd or hdmi
power(clock and regulator). actually, previous codes called mode_set
two times so this could make it messed up other display sub devices
such as mDNIe.
>
>>
>> Signed-off-by: Inki Dae <inki.dae@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_encoder.c | 2 --
>> 1 files changed, 0 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> index 2c037cd..3dae250 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c
>> @@ -138,8 +138,6 @@ static void exynos_drm_encoder_mode_set(struct
>> drm_encoder *encoder,
>> DRM_DEBUG_KMS("%s\n", __FILE__);
>> - exynos_drm_encoder_dpms(encoder, DRM_MODE_DPMS_ON);
>> -
>> list_for_each_entry(connector, &dev->mode_config.connector_list,
>> head) {
>> if (connector->encoder == encoder)
>> if (manager_ops && manager_ops->mode_set)
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-08-20 2:00 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 9:50 [PATCH 00/13] updated exynos-drm-fixes Inki Dae
2012-08-17 9:50 ` [PATCH 01/13] drm/exynos: added device object to subdrv's remove callback as argument Inki Dae
2012-08-17 9:50 ` [PATCH 02/13] drm/exynos: separated subdrv->probe call and encoder/connector creation Inki Dae
2012-08-20 1:11 ` Joonyoung Shim
2012-08-20 1:52 ` InKi Dae
2012-08-20 1:59 ` Joonyoung Shim
2012-08-20 4:31 ` InKi Dae
2012-08-20 4:42 ` Joonyoung Shim
2012-08-20 5:43 ` InKi Dae
2012-08-17 9:50 ` [PATCH 03/13] drm/exynos: fixed page align bug Inki Dae
2012-08-17 9:50 ` [PATCH 04/13] drm/exynos: use empty function instead of drm_helper_connector_dpms Inki Dae
2012-08-20 1:12 ` Joonyoung Shim
2012-08-20 2:50 ` InKi Dae
2012-08-17 9:50 ` [PATCH 05/13] drm/exynos: removed exynos_drm_encoder_dpms call Inki Dae
2012-08-20 1:14 ` Joonyoung Shim
2012-08-20 2:00 ` InKi Dae [this message]
2012-08-17 9:50 ` [PATCH 06/13] drm/exynos: separeated fimd_power_on into some parts Inki Dae
2012-08-17 9:50 ` [PATCH 07/13] drm/exynos: control display power at connector module Inki Dae
2012-08-17 9:50 ` [PATCH 08/13] drm/exynos: make sure that hardware overlay for fimd is disabled Inki Dae
2012-08-20 2:09 ` Joonyoung Shim
2012-08-17 9:50 ` [PATCH 09/13] drm/exynos: check NV12M format specific to Exynos properly Inki Dae
2012-08-20 1:17 ` Joonyoung Shim
2012-08-20 2:23 ` InKi Dae
2012-08-20 4:52 ` Joonyoung Shim
2012-08-20 5:11 ` InKi Dae
2012-08-20 5:15 ` InKi Dae
2012-08-20 5:22 ` Joonyoung Shim
2012-08-20 5:45 ` InKi Dae
2012-08-17 9:50 ` [PATCH 10/13] drm/exynos: update crtc to plane safely Inki Dae
2012-08-20 1:25 ` Joonyoung Shim
2012-08-17 9:50 ` [PATCH 11/13] drm/exynos: changed context name of hdmi and mixer Inki Dae
2012-08-20 1:27 ` Joonyoung Shim
2012-08-20 2:29 ` InKi Dae
2012-08-20 4:55 ` Joonyoung Shim
2012-08-20 6:17 ` InKi Dae
2012-08-20 6:36 ` Joonyoung Shim
2012-08-20 6:51 ` InKi Dae
2012-08-20 7:30 ` InKi Dae
2012-08-17 9:50 ` [PATCH 12/13] drm/exynos: fixed build warning Inki Dae
2012-08-17 9:50 ` [PATCH 13/13] drm/exynos: make sure that hardware overlay for hdmi is disabled Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAQKjZMHzORsVyvSYtux+QX_u-+jkRyiER-txg=ny8Aq6+CVuA@mail.gmail.com' \
--to=inki.dae@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jy0922.shim@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.