From: InKi Dae <inki.dae@samsung.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: linux@arm.linux.org.uk, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm/exynos: fix EDID memory leak in HDMI
Date: Wed, 22 Aug 2012 13:21:08 +0900 [thread overview]
Message-ID: <CAAQKjZOFRV7gBRZ2RMTv=X2pxs_DNEat8k2_=6pVLt06P8JWnA@mail.gmail.com> (raw)
In-Reply-To: <36e2490cdd41a21e31cba18ce5ad2d92cecbad98.1345022231.git.jani.nikula@intel.com>
2012/8/15 Jani Nikula <jani.nikula@intel.com>:
> The EDID returned by drm_get_edid() was never freed.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/exynos/exynos_hdmi.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 409e2ec..b55335b 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c
> @@ -1282,6 +1282,7 @@ static int hdmi_get_edid(void *ctx, struct drm_connector *connector,
> DRM_DEBUG_KMS("%s : width[%d] x height[%d]\n",
> (hdata->dvi_mode ? "dvi monitor" : "hdmi monitor"),
> raw_edid->width_cm, raw_edid->height_cm);
> + kfree(raw_edid);
Applied, Thanks.
> } else {
> return -ENODEV;
> }
> --
> 1.7.4.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-08-22 4:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-11 16:51 [BUG] EDID leaks kernel memory Russell King - ARM Linux
2012-08-13 14:24 ` Daniel Vetter
2012-08-15 9:32 ` [PATCH 0/4] remove raw_edid, and fix related memory leaks Jani Nikula
2012-08-15 9:32 ` [PATCH 1/4] drm/i915: fix EDID memory leak in SDVO Jani Nikula
2012-08-15 22:45 ` Daniel Vetter
2012-08-15 9:32 ` [PATCH 2/4] drm/ast: fix EDID memory leak Jani Nikula
2012-08-15 9:32 ` [PATCH 3/4] drm/exynos: fix EDID memory leak in HDMI Jani Nikula
2012-08-22 4:21 ` InKi Dae [this message]
2012-08-15 9:32 ` [PATCH 4/4] drm: remove the raw_edid field from struct drm_display_info Jani Nikula
2012-08-22 5:18 ` InKi Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAQKjZOFRV7gBRZ2RMTv=X2pxs_DNEat8k2_=6pVLt06P8JWnA@mail.gmail.com' \
--to=inki.dae@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.