Re: [PATCH] hwmon: (w83773g) Fix fault detection and reporting

From: Lei YU <mine260309@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Hardware Monitoring <linux-hwmon@vger.kernel.org>,
	Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH] hwmon: (w83773g) Fix fault detection and reporting
Date: Mon, 4 Dec 2017 12:23:46 +0800	[thread overview]
Message-ID: <CAARXrtmg-DYb7W_yZeVqMJz3P9LSPKoWSMOUTcmnHDsm7ZoaxA@mail.gmail.com> (raw)
In-Reply-To: <1512353636-13985-1-git-send-email-linux@roeck-us.net>

Reviewed-by: Lei YU <mine260309@gmail.com>

Thanks for catching this.

On Mon, Dec 4, 2017 at 10:13 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> Smatch reports:
>
> drivers/hwmon/w83773g.c:105
>         get_fault() warn: shift has higher precedence than mask
>
> Code analysis shows that the code is indeed wrong.
> Fix it, and while we are at it, drop unnecessary typecast.
>
> Fixes: 86a10c802362 ("hwmon: Add W83773G driver")
> Cc: Lei YU <mine260309@gmail.com>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
>  drivers/hwmon/w83773g.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/w83773g.c b/drivers/hwmon/w83773g.c
> index 0b97c285b049..e858093ac806 100644
> --- a/drivers/hwmon/w83773g.c
> +++ b/drivers/hwmon/w83773g.c
> @@ -102,7 +102,7 @@ static int get_fault(struct regmap *regmap, int index, long *val)
>         if (ret < 0)
>                 return ret;
>
> -       *val = (u8)regval & 0x04 >> 2;
> +       *val = (regval & 0x04) >> 2;
>         return 0;
>  }
>
> --
> 2.7.4
>