All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Rasmussen <sebras@gmail.com>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: chris@printf.net, linux-mmc@vger.kernel.org,
	Ulf Hansson <ulf.hansson@linaro.org>,
	broonie@kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v2] mmc-utils: Merge the lsmmc tool into mmc-utils
Date: Tue, 2 Feb 2016 23:04:43 +0100	[thread overview]
Message-ID: <CAAgDR1Mb5utsrVD9V3QOvPPOD+bRfyMwoRfn-B=9OxgY0v=ezQ@mail.gmail.com> (raw)
In-Reply-To: <d59ece1ff066b7fd7c8b538a560f726751fb1f9a.1454401105.git.baolin.wang@linaro.org>

> The original code is created by Sebastian Rasmussen and still lives in
> private git.

Actually the company at which I developed the code has since been
dissolved so I believe that the only place where this code currently
lives is as an attachment in the mail archive of linux-mmc.

> It need to be merged into mmc-utils repository, which is
> convenient for testing MMC device from userspace.

I fully agree. Though maybe the subcommands csd/cid/scr read all should be
brought to conform to the other subcommands in terms of using e.g.
CHECK() and checking for errors using perror(). Basically I would want
the new subcommands to be indistiguishable from the existing commands.
Even if I developed the code at my previous employer it just looks
nasty if it is tacked on without being a proper part of the existing
code. :)

Also I'm a bit wary of that lsmmc.ids database as it is currently not
installed if you do "make install" as it probably should be. Maybe it
is better to hardcode this internally in the program and avoid having
to deal with installation?

Either way, I'm happy to continue working getting this into mmc-utils.

 / Sebastian

  parent reply	other threads:[~2016-02-02 22:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02  8:21 [PATCH v2] mmc-utils: Merge the lsmmc tool into mmc-utils Baolin Wang
2016-02-02 21:39 ` Linus Walleij
2016-02-03  2:26   ` Baolin Wang
2016-02-02 22:04 ` Sebastian Rasmussen [this message]
2016-02-03  2:34   ` Baolin Wang
2016-02-05  8:23 Baolin Wang
2016-02-05  9:29 ` Linus Walleij
2016-02-05 15:17   ` Sebastian Rasmussen
2016-02-16 20:02 ` Chris Ball
2016-02-17  2:31   ` Baolin Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAgDR1Mb5utsrVD9V3QOvPPOD+bRfyMwoRfn-B=9OxgY0v=ezQ@mail.gmail.com' \
    --to=sebras@gmail.com \
    --cc=baolin.wang@linaro.org \
    --cc=broonie@kernel.org \
    --cc=chris@printf.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.